Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Unified Diff: chrome/browser/chromeos/file_system_provider/provided_file_system.h

Issue 703123003: [fsp] Pass more detailed errors to the providing extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a bug. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/provided_file_system.h
diff --git a/chrome/browser/chromeos/file_system_provider/provided_file_system.h b/chrome/browser/chromeos/file_system_provider/provided_file_system.h
index 3f8b7a63c3fc876ebb741775ebc6e129c57e69d7..9c5dd3a019ac1264a4126f5ab53c609bdac108de 100644
--- a/chrome/browser/chromeos/file_system_provider/provided_file_system.h
+++ b/chrome/browser/chromeos/file_system_provider/provided_file_system.h
@@ -156,11 +156,13 @@ class ProvidedFileSystem : public ProvidedFileSystemInterface {
virtual Watchers* GetWatchers() override;
virtual void AddObserver(ProvidedFileSystemObserver* observer) override;
virtual void RemoveObserver(ProvidedFileSystemObserver* observer) override;
- virtual bool Notify(const base::FilePath& entry_path,
- bool recursive,
- storage::WatcherManager::ChangeType change_type,
- scoped_ptr<ProvidedFileSystemObserver::Changes> changes,
- const std::string& tag) override;
+ virtual void Notify(
+ const base::FilePath& entry_path,
+ bool recursive,
+ storage::WatcherManager::ChangeType change_type,
+ scoped_ptr<ProvidedFileSystemObserver::Changes> changes,
+ const std::string& tag,
+ const storage::AsyncFileUtil::StatusCallback& callback) override;
virtual base::WeakPtr<ProvidedFileSystemInterface> GetWeakPtr() override;
private:
@@ -179,14 +181,14 @@ class ProvidedFileSystem : public ProvidedFileSystemInterface {
base::File::Error result);
// Called when all observers finished handling the change notification. It
- // updates the tag from |last_tag| to |tag| for the entry at |entry_path|.
+ // updates the tag to |tag| for the entry at |entry_path|.
void OnNotifyCompleted(
const base::FilePath& entry_path,
bool recursive,
storage::WatcherManager::ChangeType change_type,
scoped_ptr<ProvidedFileSystemObserver::Changes> changes,
- const std::string& last_tag,
- const std::string& tag);
+ const std::string& tag,
+ const storage::AsyncFileUtil::StatusCallback& callback);
Profile* profile_; // Not owned.
extensions::EventRouter* event_router_; // Not owned. May be NULL.

Powered by Google App Engine
This is Rietveld 408576698