Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc

Issue 703123003: [fsp] Pass more detailed errors to the providing extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a bug. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc
diff --git a/chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc b/chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc
index cc2bf5d949097d220f3103a2c62d4ac7bc24f853..e14f47ed10e03dd984f3d36e5a9a62cd4eb44c3f 100644
--- a/chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc
+++ b/chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc
@@ -127,9 +127,10 @@ TEST_F(FileSystemProviderMountPathUtilTest, IsFileSystemProviderLocalPath) {
}
TEST_F(FileSystemProviderMountPathUtilTest, Parser) {
- const bool result = file_system_provider_service_->MountFileSystem(
- kExtensionId, MountOptions(kFileSystemId, kDisplayName));
- ASSERT_TRUE(result);
+ const base::File::Error result =
+ file_system_provider_service_->MountFileSystem(
+ kExtensionId, MountOptions(kFileSystemId, kDisplayName));
+ ASSERT_EQ(base::File::FILE_OK, result);
const ProvidedFileSystemInfo file_system_info =
file_system_provider_service_->GetProvidedFileSystem(kExtensionId,
kFileSystemId)
@@ -151,9 +152,10 @@ TEST_F(FileSystemProviderMountPathUtilTest, Parser) {
}
TEST_F(FileSystemProviderMountPathUtilTest, Parser_RootPath) {
- const bool result = file_system_provider_service_->MountFileSystem(
- kExtensionId, MountOptions(kFileSystemId, kDisplayName));
- ASSERT_TRUE(result);
+ const base::File::Error result =
+ file_system_provider_service_->MountFileSystem(
+ kExtensionId, MountOptions(kFileSystemId, kDisplayName));
+ ASSERT_EQ(base::File::FILE_OK, result);
const ProvidedFileSystemInfo file_system_info =
file_system_provider_service_->GetProvidedFileSystem(kExtensionId,
kFileSystemId)
@@ -191,9 +193,10 @@ TEST_F(FileSystemProviderMountPathUtilTest, Parser_WrongUrl) {
}
TEST_F(FileSystemProviderMountPathUtilTest, Parser_IsolatedURL) {
- const bool result = file_system_provider_service_->MountFileSystem(
- kExtensionId, MountOptions(kFileSystemId, kDisplayName));
- ASSERT_TRUE(result);
+ const base::File::Error result =
+ file_system_provider_service_->MountFileSystem(
+ kExtensionId, MountOptions(kFileSystemId, kDisplayName));
+ ASSERT_EQ(base::File::FILE_OK, result);
const ProvidedFileSystemInfo file_system_info =
file_system_provider_service_->GetProvidedFileSystem(kExtensionId,
kFileSystemId)
@@ -237,9 +240,10 @@ TEST_F(FileSystemProviderMountPathUtilTest, Parser_IsolatedURL) {
}
TEST_F(FileSystemProviderMountPathUtilTest, LocalPathParser) {
- const bool result = file_system_provider_service_->MountFileSystem(
- kExtensionId, MountOptions(kFileSystemId, kDisplayName));
- ASSERT_TRUE(result);
+ const base::File::Error result =
+ file_system_provider_service_->MountFileSystem(
+ kExtensionId, MountOptions(kFileSystemId, kDisplayName));
+ ASSERT_EQ(base::File::FILE_OK, result);
const ProvidedFileSystemInfo file_system_info =
file_system_provider_service_->GetProvidedFileSystem(kExtensionId,
kFileSystemId)
@@ -261,9 +265,10 @@ TEST_F(FileSystemProviderMountPathUtilTest, LocalPathParser) {
}
TEST_F(FileSystemProviderMountPathUtilTest, LocalPathParser_RootPath) {
- const bool result = file_system_provider_service_->MountFileSystem(
- kExtensionId, MountOptions(kFileSystemId, kDisplayName));
- ASSERT_TRUE(result);
+ const base::File::Error result =
+ file_system_provider_service_->MountFileSystem(
+ kExtensionId, MountOptions(kFileSystemId, kDisplayName));
+ ASSERT_EQ(base::File::FILE_OK, result);
const ProvidedFileSystemInfo file_system_info =
file_system_provider_service_->GetProvidedFileSystem(kExtensionId,
kFileSystemId)

Powered by Google App Engine
This is Rietveld 408576698