Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/chromeos/file_system_provider/request_manager.h

Issue 703123003: [fsp] Pass more detailed errors to the providing extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a bug. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/request_manager.h
diff --git a/chrome/browser/chromeos/file_system_provider/request_manager.h b/chrome/browser/chromeos/file_system_provider/request_manager.h
index 913408b562ac2e2184849659d27caca7f043cdf9..ccc87d83be672d94c45ada069e71e04861f16acb 100644
--- a/chrome/browser/chromeos/file_system_provider/request_manager.h
+++ b/chrome/browser/chromeos/file_system_provider/request_manager.h
@@ -113,17 +113,19 @@ class RequestManager {
int CreateRequest(RequestType type, scoped_ptr<HandlerInterface> handler);
// Handles successful response for the |request_id|. If |has_more| is false,
- // then the request is disposed, after handling the |response|. On error,
- // returns false, and the request is disposed. |response| must not be NULL.
- bool FulfillRequest(int request_id,
- scoped_ptr<RequestValue> response,
- bool has_more);
-
- // Handles error response for the |request_id|. If handling the error fails,
- // returns false. Always disposes the request. |response| must not be NULL.
- bool RejectRequest(int request_id,
- scoped_ptr<RequestValue> response,
- base::File::Error error);
+ // then the request is disposed, after handling the |response|. On success,
+ // returns base::File::FILE_OK. Otherwise returns an error code. |response|
+ // must not be NULL.
+ base::File::Error FulfillRequest(int request_id,
+ scoped_ptr<RequestValue> response,
+ bool has_more);
+
+ // Handles error response for the |request_id|. If handling the error
+ // succeeds, theen returns base::File::FILE_OK. Otherwise returns an error
+ // code. Always disposes the request. |response| must not be NULL.
+ base::File::Error RejectRequest(int request_id,
+ scoped_ptr<RequestValue> response,
+ base::File::Error error);
// Sets a custom timeout for tests. The new timeout value will be applied to
// new requests

Powered by Google App Engine
This is Rietveld 408576698