Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3558)

Unified Diff: chrome/browser/chromeos/file_system_provider/service.h

Issue 703123003: [fsp] Pass more detailed errors to the providing extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed a bug. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_system_provider/service.h
diff --git a/chrome/browser/chromeos/file_system_provider/service.h b/chrome/browser/chromeos/file_system_provider/service.h
index e6eb3cfd436a5bc0c98b21425d7e8c2eeb8ab194..5d6e97939c0d1f482a89bbf4bb869df9cb027f22 100644
--- a/chrome/browser/chromeos/file_system_provider/service.h
+++ b/chrome/browser/chromeos/file_system_provider/service.h
@@ -82,15 +82,16 @@ class Service : public KeyedService,
// Otherwise, only read-only operations are supported. If change notification
// tags are supported, then |supports_notify_tag| must be true. Note, that
// it is required in order to enable the internal cache. For success, returns
- // true, otherwise false.
- bool MountFileSystem(const std::string& extension_id,
- const MountOptions& options);
+ // base::File::FILE_OK, otherwise an error code.
+ base::File::Error MountFileSystem(const std::string& extension_id,
+ const MountOptions& options);
// Unmounts a file system with the specified |file_system_id| for the
- // |extension_id|. For success returns true, otherwise false.
- bool UnmountFileSystem(const std::string& extension_id,
- const std::string& file_system_id,
- UnmountReason reason);
+ // |extension_id|. For success returns base::File::FILE_OK, otherwise an error
+ // code.
+ base::File::Error UnmountFileSystem(const std::string& extension_id,
+ const std::string& file_system_id,
+ UnmountReason reason);
// Requests unmounting of the file system. The callback is called when the
// request is accepted or rejected, with an error code. Returns false if the

Powered by Google App Engine
This is Rietveld 408576698