[fsp] Pass more detailed errors to the providing extension.

chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h"
 
 #include <string>
 #include <vector>
 
 #include "base/debug/trace_event.h"
@@ skipping 59 matching lines @@
 
 }  // namespace
 
 bool FileSystemProviderMountFunction::RunSync() {
   using api::file_system_provider::Mount::Params;
   const scoped_ptr<Params> params(Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
   // It's an error if the file system Id is empty.
   if (params->options.file_system_id.empty()) {
-    SetError(FileErrorToString(base::File::FILE_ERROR_SECURITY));
+    SetError(FileErrorToString(base::File::FILE_ERROR_INVALID_OPERATION));
     return false;
   }
 
   // It's an error if the display name is empty.
   if (params->options.display_name.empty()) {
-    SetError(FileErrorToString(base::File::FILE_ERROR_SECURITY));
+    SetError(FileErrorToString(base::File::FILE_ERROR_INVALID_OPERATION));
     return false;
   }
 
   Service* const service = Service::Get(GetProfile());
   DCHECK(service);
 
   MountOptions options;
   options.file_system_id = params->options.file_system_id;
   options.display_name = params->options.display_name;
   options.writable = params->options.writable;
   options.supports_notify_tag = params->options.supports_notify_tag;
 
-  // TODO(mtomasz): Pass more detailed errors, rather than just a bool.
-  if (!service->MountFileSystem(extension_id(), options)) {
-    SetError(FileErrorToString(base::File::FILE_ERROR_SECURITY));
+  const base::File::Error result =
+      service->MountFileSystem(extension_id(), options);
+  if (result != base::File::FILE_OK) {
+    SetError(FileErrorToString(result));
     return false;
   }
 
   return true;
 }
 
 bool FileSystemProviderUnmountFunction::RunSync() {
   using api::file_system_provider::Unmount::Params;
   scoped_ptr<Params> params(Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
   Service* const service = Service::Get(GetProfile());
   DCHECK(service);
 
-  if (!service->UnmountFileSystem(extension_id(),
-                                  params->options.file_system_id,
-                                  Service::UNMOUNT_REASON_USER)) {
-    // TODO(mtomasz): Pass more detailed errors, rather than just a bool.
-    SetError(FileErrorToString(base::File::FILE_ERROR_SECURITY));
+  const base::File::Error result =
+      service->UnmountFileSystem(extension_id(), params->options.file_system_id,
+                                 Service::UNMOUNT_REASON_USER);
+  if (result != base::File::FILE_OK) {
+    SetError(FileErrorToString(result));
     return false;
   }
 
   return true;
 }
 
 bool FileSystemProviderGetAllFunction::RunSync() {
   using api::file_system_provider::FileSystemInfo;
   using api::file_system_provider::Watcher;
   Service* const service = Service::Get(GetProfile());
@@ skipping 33 matching lines @@
 
       item->watchers = watcher_items;
       items.push_back(item);
     }
   }
 
   SetResultList(api::file_system_provider::GetAll::Results::Create(items));
   return true;
 }
 
-bool FileSystemProviderNotifyFunction::RunSync() {
+bool FileSystemProviderNotifyFunction::RunAsync() {
   using api::file_system_provider::Notify::Params;
   scoped_ptr<Params> params(Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
   Service* const service = Service::Get(GetProfile());
   DCHECK(service);
 
   ProvidedFileSystemInterface* const file_system =
       service->GetProvidedFileSystem(extension_id(),
                                      params->options.file_system_id);
   if (!file_system) {
-    SetError(FileErrorToString(base::File::FILE_ERROR_SECURITY));
+    SetError(FileErrorToString(base::File::FILE_ERROR_NOT_FOUND));
     return false;
   }
 
-  if (!file_system->Notify(
-          base::FilePath::FromUTF8Unsafe(params->options.observed_path),
-          params->options.recursive,
-          ParseChangeType(params->options.change_type),
-          params->options.changes.get()
-              ? ParseChanges(*params->options.changes.get())
-              : make_scoped_ptr(new ProvidedFileSystemObserver::Changes),
-          params->options.tag.get() ? *params->options.tag.get() : "")) {
-    SetError(FileErrorToString(base::File::FILE_ERROR_SECURITY));
-    return false;
+  file_system->Notify(
+      base::FilePath::FromUTF8Unsafe(params->options.observed_path),
+      params->options.recursive, ParseChangeType(params->options.change_type),
+      params->options.changes.get()
+          ? ParseChanges(*params->options.changes.get())
+          : make_scoped_ptr(new ProvidedFileSystemObserver::Changes),
+      params->options.tag.get() ? *params->options.tag.get() : "",
+      base::Bind(&FileSystemProviderNotifyFunction::OnNotifyCompleted, this));
+
+  return true;
+}
+
+void FileSystemProviderNotifyFunction::OnNotifyCompleted(
+    base::File::Error result) {
+  if (result != base::File::FILE_OK) {
+    SetError(FileErrorToString(result));
+    SendResponse(false);
+    return;
   }
 
-  return true;
+  SendResponse(true);
 }
 
 bool FileSystemProviderInternalUnmountRequestedSuccessFunction::RunWhenValid() {
   using api::file_system_provider_internal::UnmountRequestedSuccess::Params;
   scoped_ptr<Params> params(Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
   return FulfillRequest(RequestValue::CreateForUnmountSuccess(params.Pass()),
                         false /* has_more */);
 }
@@ skipping 50 matching lines @@
   using api::file_system_provider_internal::OperationRequestedError::Params;
   scoped_ptr<Params> params(Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
   const base::File::Error error = ProviderErrorToFileError(params->error);
   return RejectRequest(RequestValue::CreateForOperationError(params.Pass()),
                        error);
 }
 
 }  // namespace extensions