[fsp] Pass more detailed errors to the providing extension.

chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_system_provider/provided_file_system.h"
 
 #include <string>
 #include <vector>
 
 #include "base/files/file.h"
@@ skipping 739 matching lines @@
     EXPECT_EQ(1u, watchers->size());
     provided_file_system_->GetWatchers();
     EXPECT_EQ("", watchers->begin()->second.last_tag);
   }
 
   {
     // Notify about a change.
     const storage::WatcherManager::ChangeType change_type =
         storage::WatcherManager::CHANGED;
     const std::string tag = "hello-world";
-    EXPECT_TRUE(provided_file_system_->Notify(
-        base::FilePath::FromUTF8Unsafe(kDirectoryPath),
-        false /* recursive */,
-        change_type,
-        make_scoped_ptr(new ProvidedFileSystemObserver::Changes),
-        tag));
+
+    Log log;
+    provided_file_system_->Notify(
+        base::FilePath::FromUTF8Unsafe(kDirectoryPath), false /* recursive */,
+        change_type, make_scoped_ptr(new ProvidedFileSystemObserver::Changes),
+        tag, base::Bind(&LogStatus, base::Unretained(&log)));
 
     // Confirm that the notification callback was called.
     ASSERT_EQ(1u, notification_log.size());
     EXPECT_EQ(change_type, notification_log[0]);
 
     // Verify the observer event.
     ASSERT_EQ(1u, observer.change_events().size());
     const Observer::ChangeEvent* const change_event =
         observer.change_events()[0];
     EXPECT_EQ(change_type, change_event->change_type());
     EXPECT_EQ(0u, change_event->changes().size());
 
     // The tag should not be updated in advance, before all observers handle
     // the notification.
     Watchers* const watchers = provided_file_system_->GetWatchers();
     EXPECT_EQ(1u, watchers->size());
     provided_file_system_->GetWatchers();
     EXPECT_EQ("", watchers->begin()->second.last_tag);
 
     // Wait until all observers finish handling the notification.
     base::RunLoop().RunUntilIdle();
 
+    ASSERT_EQ(1u, log.size());
+    EXPECT_EQ(base::File::FILE_OK, log[0]);
+
     // Confirm, that the watcher still exists, and that the tag is updated.
     ASSERT_EQ(1u, watchers->size());
     EXPECT_EQ(tag, watchers->begin()->second.last_tag);
     EXPECT_EQ(1, observer.list_changed_counter());
     EXPECT_EQ(1, observer.tag_updated_counter());
   }
 
   {
     // Notify about deleting of the watched entry.
     const storage::WatcherManager::ChangeType change_type =
         storage::WatcherManager::DELETED;
     const ProvidedFileSystemObserver::Changes changes;
     const std::string tag = "chocolate-disco";
-    EXPECT_TRUE(provided_file_system_->Notify(
-        base::FilePath::FromUTF8Unsafe(kDirectoryPath),
-        false /* recursive */,
-        change_type,
-        make_scoped_ptr(new ProvidedFileSystemObserver::Changes),
-        tag));
+
+    Log log;
+    provided_file_system_->Notify(
+        base::FilePath::FromUTF8Unsafe(kDirectoryPath), false /* recursive */,
+        change_type, make_scoped_ptr(new ProvidedFileSystemObserver::Changes),
+        tag, base::Bind(&LogStatus, base::Unretained(&log)));
     base::RunLoop().RunUntilIdle();
+    ASSERT_EQ(1u, log.size());
+    EXPECT_EQ(base::File::FILE_OK, log[0]);
 
     // Confirm that the notification callback was called.
     ASSERT_EQ(2u, notification_log.size());
     EXPECT_EQ(change_type, notification_log[1]);
 
     // Verify the observer event.
     ASSERT_EQ(2u, observer.change_events().size());
     const Observer::ChangeEvent* const change_event =
         observer.change_events()[1];
     EXPECT_EQ(change_type, change_event->change_type());
     EXPECT_EQ(0u, change_event->changes().size());
   }
 
   // Confirm, that the watcher is removed.
   {
     Watchers* const watchers = provided_file_system_->GetWatchers();
     EXPECT_EQ(0u, watchers->size());
     EXPECT_EQ(2, observer.list_changed_counter());
     EXPECT_EQ(2, observer.tag_updated_counter());
   }
 
   provided_file_system_->RemoveObserver(&observer);
 }
 
 }  // namespace file_system_provider
 }  // namespace chromeos