Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1826)

Issue 699313007: minidump: Use the crashpad::internal namespace more appropriately (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

minidump: Use the crashpad::internal namespace more appropriately. MinidumpLocationDescriptorListWriter and MinidumpRVAListWriter are implementation details and should be in the crashpad::internal namespace. MinidumpUTF16StringListWriter and MinidumpUTF8StringListWriter are accessible to outside code and should not be in this namespace. TEST=minidump_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9386a054e2a51673249d2ae51d5249c8a85b2b4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -63 lines) Patch
M minidump/minidump_location_descriptor_list_writer.h View 2 chunks +7 lines, -6 lines 0 comments Download
M minidump/minidump_location_descriptor_list_writer.cc View 4 chunks +4 lines, -2 lines 0 comments Download
M minidump/minidump_location_descriptor_list_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_module_crashpad_info_writer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M minidump/minidump_module_crashpad_info_writer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M minidump/minidump_module_crashpad_info_writer_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M minidump/minidump_rva_list_writer.h View 2 chunks +6 lines, -5 lines 0 comments Download
M minidump/minidump_rva_list_writer.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M minidump/minidump_rva_list_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_string_writer.h View 3 chunks +10 lines, -23 lines 0 comments Download
M minidump/minidump_string_writer.cc View 2 chunks +13 lines, -12 lines 0 comments Download
M minidump/minidump_string_writer_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
6 years, 1 month ago (2014-11-07 16:36:03 UTC) #2
Robert Sesek
LGTM. I was thinking this when you sent the StringListWriter.
6 years, 1 month ago (2014-11-07 16:39:12 UTC) #3
Mark Mentovai
Shoulda said something, I didn’t realize I had goofed on this until after it was ...
6 years, 1 month ago (2014-11-07 16:45:29 UTC) #4
Mark Mentovai
6 years, 1 month ago (2014-11-07 16:45:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9386a054e2a51673249d2ae51d5249c8a85b2b4e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698