Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: minidump/minidump_rva_list_writer.cc

Issue 699313007: minidump: Use the crashpad::internal namespace more appropriately (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « minidump/minidump_rva_list_writer.h ('k') | minidump/minidump_rva_list_writer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_rva_list_writer.cc
diff --git a/minidump/minidump_rva_list_writer.cc b/minidump/minidump_rva_list_writer.cc
index af4f5824069d69b7b480d75cb7c2b91122f1ca12..70ffe4f017acd650659ff96b28dcfdebe3529241 100644
--- a/minidump/minidump_rva_list_writer.cc
+++ b/minidump/minidump_rva_list_writer.cc
@@ -19,6 +19,7 @@
#include "util/numeric/safe_assignment.h"
namespace crashpad {
+namespace internal {
MinidumpRVAListWriter::MinidumpRVAListWriter()
: MinidumpWritable(),
@@ -30,8 +31,7 @@ MinidumpRVAListWriter::MinidumpRVAListWriter()
MinidumpRVAListWriter::~MinidumpRVAListWriter() {
}
-void MinidumpRVAListWriter::AddChild(
- scoped_ptr<internal::MinidumpWritable> child) {
+void MinidumpRVAListWriter::AddChild(scoped_ptr<MinidumpWritable> child) {
DCHECK_EQ(state(), kStateMutable);
children_.push_back(child.release());
@@ -65,7 +65,7 @@ size_t MinidumpRVAListWriter::SizeOfObject() {
return sizeof(rva_list_base_) + children_.size() * sizeof(RVA);
}
-std::vector<internal::MinidumpWritable*> MinidumpRVAListWriter::Children() {
+std::vector<MinidumpWritable*> MinidumpRVAListWriter::Children() {
DCHECK_GE(state(), kStateFrozen);
std::vector<MinidumpWritable*> children;
@@ -94,4 +94,5 @@ bool MinidumpRVAListWriter::WriteObject(FileWriterInterface* file_writer) {
return file_writer->WriteIoVec(&iovecs);
}
+} // namespace internal
} // namespace crashpad
« no previous file with comments | « minidump/minidump_rva_list_writer.h ('k') | minidump/minidump_rva_list_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698