minidump: Use the crashpad::internal namespace more appropriately

minidump/minidump_string_writer.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 77 matching lines @@
 
 void MinidumpUTF16StringWriter::SetUTF8(const std::string& string_utf8) {
   DCHECK_EQ(state(), kStateMutable);
 
   set_string(MinidumpWriterUtil::ConvertUTF8ToUTF16(string_utf8));
 }
 
 MinidumpUTF8StringWriter::~MinidumpUTF8StringWriter() {
 }
 
-template <typename Traits>
-MinidumpStringListWriter<Traits>::MinidumpStringListWriter()
+template <typename MinidumpStringWriterType>
+MinidumpStringListWriter<MinidumpStringWriterType>::MinidumpStringListWriter()
     : MinidumpRVAListWriter() {
 }
 
-template <typename Traits>
-MinidumpStringListWriter<Traits>::~MinidumpStringListWriter() {
+template <typename MinidumpStringWriterType>
+MinidumpStringListWriter<
+    MinidumpStringWriterType>::~MinidumpStringListWriter() {
 }
 
-template <typename Traits>
-void MinidumpStringListWriter<Traits>::InitializeFromVector(
+template <typename MinidumpStringWriterType>
+void MinidumpStringListWriter<MinidumpStringWriterType>::InitializeFromVector(
     const std::vector<std::string>& vector) {
   DCHECK_EQ(state(), kStateMutable);
   DCHECK(IsEmpty());
 
   for (const std::string& string : vector) {
     AddStringUTF8(string);
   }
 }
 
-template <typename Traits>
-void MinidumpStringListWriter<Traits>::AddStringUTF8(
+template <typename MinidumpStringWriterType>
+void MinidumpStringListWriter<MinidumpStringWriterType>::AddStringUTF8(
     const std::string& string_utf8) {
   auto string_writer = make_scoped_ptr(new MinidumpStringWriterType());
   string_writer->SetUTF8(string_utf8);
   AddChild(string_writer.Pass());
 }
 
-template <typename Traits>
-bool MinidumpStringListWriter<Traits>::IsUseful() const {
+template <typename MinidumpStringWriterType>
+bool MinidumpStringListWriter<MinidumpStringWriterType>::IsUseful() const {
   return !IsEmpty();
 }
 
 // Explicit template instantiation of the forms of MinidumpStringListWriter<>
 // used as type aliases.
-template class MinidumpStringListWriter<MinidumpStringListWriterUTF16Traits>;
-template class MinidumpStringListWriter<MinidumpStringListWriterUTF8Traits>;
+template class MinidumpStringListWriter<MinidumpUTF16StringWriter>;
+template class MinidumpStringListWriter<MinidumpUTF8StringWriter>;
 
 }  // namespace internal
 }  // namespace crashpad