minidump/minidump_module_crashpad_info_writer_test.cc - Issue 699313007: minidump: Use the crashpad::internal namespace more appropriately

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_module_crashpad_info_writer_test.cc

Issue 699313007: minidump: Use the crashpad::internal namespace more appropriately (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_module_crashpad_info_writer_test.cc

diff --git a/minidump/minidump_module_crashpad_info_writer_test.cc b/minidump/minidump_module_crashpad_info_writer_test.cc

index 47aa760187312fb59af3d615540397a0f21b1113..50621f9fc9ecaf321170e43baa77246d1b7b6e44 100644

--- a/minidump/minidump_module_crashpad_info_writer_test.cc

+++ b/minidump/minidump_module_crashpad_info_writer_test.cc

@@ -90,8 +90,7 @@ TEST(MinidumpModuleCrashpadInfoWriter, FullModule) {

auto module_writer =

make_scoped_ptr(new MinidumpModuleCrashpadInfoWriter());

module_writer->SetMinidumpModuleListIndex(kMinidumpModuleListIndex);

- auto string_list_writer =

- make_scoped_ptr(new internal::MinidumpUTF8StringListWriter());

+ auto string_list_writer = make_scoped_ptr(new MinidumpUTF8StringListWriter());

string_list_writer->InitializeFromVector(vector);

module_writer->SetListAnnotations(string_list_writer.Pass());

auto simple_string_dictionary_writer =

« no previous file with comments | « minidump/minidump_module_crashpad_info_writer.cc ('k') | minidump/minidump_rva_list_writer.h » ('j') | no next file with comments »