Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: minidump/minidump_location_descriptor_list_writer.cc

Issue 699313007: minidump: Use the crashpad::internal namespace more appropriately (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: minidump/minidump_location_descriptor_list_writer.cc
diff --git a/minidump/minidump_location_descriptor_list_writer.cc b/minidump/minidump_location_descriptor_list_writer.cc
index b3f6d9e8fe44fe5534ebb4624e69b9504f754caf..f4f23a941b99be1a39e082970f5592c9a3ea9541 100644
--- a/minidump/minidump_location_descriptor_list_writer.cc
+++ b/minidump/minidump_location_descriptor_list_writer.cc
@@ -19,6 +19,7 @@
#include "util/numeric/safe_assignment.h"
namespace crashpad {
+namespace internal {
MinidumpLocationDescriptorListWriter::MinidumpLocationDescriptorListWriter()
: MinidumpWritable(),
@@ -31,7 +32,7 @@ MinidumpLocationDescriptorListWriter::~MinidumpLocationDescriptorListWriter() {
}
void MinidumpLocationDescriptorListWriter::AddChild(
- scoped_ptr<internal::MinidumpWritable> child) {
+ scoped_ptr<MinidumpWritable> child) {
DCHECK_EQ(state(), kStateMutable);
children_.push_back(child.release());
@@ -67,7 +68,7 @@ size_t MinidumpLocationDescriptorListWriter::SizeOfObject() {
children_.size() * sizeof(MINIDUMP_LOCATION_DESCRIPTOR);
}
-std::vector<internal::MinidumpWritable*>
+std::vector<MinidumpWritable*>
MinidumpLocationDescriptorListWriter::Children() {
DCHECK_GE(state(), kStateFrozen);
@@ -99,4 +100,5 @@ bool MinidumpLocationDescriptorListWriter::WriteObject(
return file_writer->WriteIoVec(&iovecs);
}
+} // namespace internal
} // namespace crashpad
« no previous file with comments | « minidump/minidump_location_descriptor_list_writer.h ('k') | minidump/minidump_location_descriptor_list_writer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698