minidump: Use the crashpad::internal namespace more appropriately

minidump/minidump_string_writer.cc

Index: minidump/minidump_string_writer.cc
diff --git a/minidump/minidump_string_writer.cc b/minidump/minidump_string_writer.cc
index effc0183694999a41730468b530c7e878e001fde..eea4eec46a12200b7120071b41dfe24e849c33e5 100644
--- a/minidump/minidump_string_writer.cc
+++ b/minidump/minidump_string_writer.cc
@@ -95,17 +95,18 @@ void MinidumpUTF16StringWriter::SetUTF8(const std::string& string_utf8) {
 MinidumpUTF8StringWriter::~MinidumpUTF8StringWriter() {
 }
 
-template <typename Traits>
-MinidumpStringListWriter<Traits>::MinidumpStringListWriter()
+template <typename MinidumpStringWriterType>
+MinidumpStringListWriter<MinidumpStringWriterType>::MinidumpStringListWriter()
     : MinidumpRVAListWriter() {
 }
 
-template <typename Traits>
-MinidumpStringListWriter<Traits>::~MinidumpStringListWriter() {
+template <typename MinidumpStringWriterType>
+MinidumpStringListWriter<
+    MinidumpStringWriterType>::~MinidumpStringListWriter() {
 }
 
-template <typename Traits>
-void MinidumpStringListWriter<Traits>::InitializeFromVector(
+template <typename MinidumpStringWriterType>
+void MinidumpStringListWriter<MinidumpStringWriterType>::InitializeFromVector(
     const std::vector<std::string>& vector) {
   DCHECK_EQ(state(), kStateMutable);
   DCHECK(IsEmpty());
@@ -115,23 +116,23 @@ void MinidumpStringListWriter<Traits>::InitializeFromVector(
   }
 }
 
-template <typename Traits>
-void MinidumpStringListWriter<Traits>::AddStringUTF8(
+template <typename MinidumpStringWriterType>
+void MinidumpStringListWriter<MinidumpStringWriterType>::AddStringUTF8(
     const std::string& string_utf8) {
   auto string_writer = make_scoped_ptr(new MinidumpStringWriterType());
   string_writer->SetUTF8(string_utf8);
   AddChild(string_writer.Pass());
 }
 
-template <typename Traits>
-bool MinidumpStringListWriter<Traits>::IsUseful() const {
+template <typename MinidumpStringWriterType>
+bool MinidumpStringListWriter<MinidumpStringWriterType>::IsUseful() const {
   return !IsEmpty();
 }
 
 // Explicit template instantiation of the forms of MinidumpStringListWriter<>
 // used as type aliases.
-template class MinidumpStringListWriter<MinidumpStringListWriterUTF16Traits>;
-template class MinidumpStringListWriter<MinidumpStringListWriterUTF8Traits>;
+template class MinidumpStringListWriter<MinidumpUTF16StringWriter>;
+template class MinidumpStringListWriter<MinidumpUTF8StringWriter>;
 
 }  // namespace internal
 }  // namespace crashpad