Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: minidump/minidump_module_crashpad_info_writer_test.cc

Issue 699313007: minidump: Use the crashpad::internal namespace more appropriately (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_module_crashpad_info_writer.cc ('k') | minidump/minidump_rva_list_writer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 const char kEntry[] = "entry"; 83 const char kEntry[] = "entry";
84 std::vector<std::string> vector(1, std::string(kEntry)); 84 std::vector<std::string> vector(1, std::string(kEntry));
85 85
86 StringFileWriter file_writer; 86 StringFileWriter file_writer;
87 87
88 MinidumpModuleCrashpadInfoListWriter module_list_writer; 88 MinidumpModuleCrashpadInfoListWriter module_list_writer;
89 89
90 auto module_writer = 90 auto module_writer =
91 make_scoped_ptr(new MinidumpModuleCrashpadInfoWriter()); 91 make_scoped_ptr(new MinidumpModuleCrashpadInfoWriter());
92 module_writer->SetMinidumpModuleListIndex(kMinidumpModuleListIndex); 92 module_writer->SetMinidumpModuleListIndex(kMinidumpModuleListIndex);
93 auto string_list_writer = 93 auto string_list_writer = make_scoped_ptr(new MinidumpUTF8StringListWriter());
94 make_scoped_ptr(new internal::MinidumpUTF8StringListWriter());
95 string_list_writer->InitializeFromVector(vector); 94 string_list_writer->InitializeFromVector(vector);
96 module_writer->SetListAnnotations(string_list_writer.Pass()); 95 module_writer->SetListAnnotations(string_list_writer.Pass());
97 auto simple_string_dictionary_writer = 96 auto simple_string_dictionary_writer =
98 make_scoped_ptr(new MinidumpSimpleStringDictionaryWriter()); 97 make_scoped_ptr(new MinidumpSimpleStringDictionaryWriter());
99 auto simple_string_dictionary_entry_writer = 98 auto simple_string_dictionary_entry_writer =
100 make_scoped_ptr(new MinidumpSimpleStringDictionaryEntryWriter()); 99 make_scoped_ptr(new MinidumpSimpleStringDictionaryEntryWriter());
101 simple_string_dictionary_entry_writer->SetKeyValue(kKey, kValue); 100 simple_string_dictionary_entry_writer->SetKeyValue(kKey, kValue);
102 simple_string_dictionary_writer->AddEntry( 101 simple_string_dictionary_writer->AddEntry(
103 simple_string_dictionary_entry_writer.Pass()); 102 simple_string_dictionary_entry_writer.Pass());
104 module_writer->SetSimpleAnnotations(simple_string_dictionary_writer.Pass()); 103 module_writer->SetSimpleAnnotations(simple_string_dictionary_writer.Pass());
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 423
425 const MinidumpSimpleStringDictionary* simple_annotations_3 = 424 const MinidumpSimpleStringDictionary* simple_annotations_3 =
426 MinidumpWritableAtLocationDescriptor<MinidumpSimpleStringDictionary>( 425 MinidumpWritableAtLocationDescriptor<MinidumpSimpleStringDictionary>(
427 file_writer.string(), module_3->simple_annotations); 426 file_writer.string(), module_3->simple_annotations);
428 EXPECT_FALSE(simple_annotations_3); 427 EXPECT_FALSE(simple_annotations_3);
429 } 428 }
430 429
431 } // namespace 430 } // namespace
432 } // namespace test 431 } // namespace test
433 } // namespace crashpad 432 } // namespace crashpad
OLDNEW
« no previous file with comments | « minidump/minidump_module_crashpad_info_writer.cc ('k') | minidump/minidump_rva_list_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698