Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 695773002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed)

Created:
6 years, 1 month ago by RAGHURAM
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings (Ref: binding-methods changed: static v8::Handle<v8::Object> associateObjectWithWrapperNonTemplate(ScriptWrappable*, const WrapperTypeInfo*, v8::Handle<v8::Object>, v8::Isolate*) static v8::Handle<v8::Object> associateObjectWithWrapperNonTemplate(Node*, const WrapperTypeInfo*, v8::Handle<v8::Object>, v8::Isolate*) static v8::Handle<v8::Object> associateObjectWithWrapper(PassRefPtr<T>, const WrapperTypeInfo*, v8::Handle<v8::Object>, v8:Isolate*) static v8::Handle<v8::Object> associateObjectWithWrapper(T*, const WrapperTypeInfo*, v8::Handle<v8::Object>, v8::Isolate*)) BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M Source/bindings/core/v8/ScriptWrappable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8DOMWrapper.h View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WorkerScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNotScriptWrappable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMArrayBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMDataView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMTypedArray.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
RAGHURAM
Please Review. Thanks & Regards
6 years, 1 month ago (2014-10-31 11:17:37 UTC) #2
RAGHURAM
On 2014/10/31 11:17:37, RAGHURAM wrote: > Please Review. > > Thanks & Regards @haraken PTAL ...
6 years, 1 month ago (2014-11-05 07:09:49 UTC) #3
haraken
LGTM
6 years, 1 month ago (2014-11-05 07:52:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695773002/1
6 years, 1 month ago (2014-11-05 09:47:13 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 10:51:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184863

Powered by Google App Engine
This is Rietveld 408576698