Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 695773002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/DOMTypedArray.cpp ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 5735 matching lines...) Expand 10 before | Expand all | Expand 10 after
5746 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , wrapperType, toScriptWrappableBase(), isolate); 5746 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , wrapperType, toScriptWrappableBase(), isolate);
5747 if (UNLIKELY(wrapper.IsEmpty())) 5747 if (UNLIKELY(wrapper.IsEmpty()))
5748 return wrapper; 5748 return wrapper;
5749 5749
5750 wrapperType->installConditionallyEnabledProperties(wrapper, isolate); 5750 wrapperType->installConditionallyEnabledProperties(wrapper, isolate);
5751 return associateWithWrapper(wrapperType, wrapper, isolate); 5751 return associateWithWrapper(wrapperType, wrapper, isolate);
5752 } 5752 }
5753 5753
5754 v8::Handle<v8::Object> Document::associateWithWrapper(const WrapperTypeInfo* wra pperType, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate) 5754 v8::Handle<v8::Object> Document::associateWithWrapper(const WrapperTypeInfo* wra pperType, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate)
5755 { 5755 {
5756 V8DOMWrapper::associateObjectWithWrapperNonTemplate(this, wrapperType, wrapp er, isolate); 5756 V8DOMWrapper::associateObjectWithWrapperNonTemplate(isolate, this, wrapperTy pe, wrapper);
5757 DOMWrapperWorld& world = DOMWrapperWorld::current(isolate); 5757 DOMWrapperWorld& world = DOMWrapperWorld::current(isolate);
5758 if (world.isMainWorld() && frame()) 5758 if (world.isMainWorld() && frame())
5759 frame()->script().windowProxy(world)->updateDocumentWrapper(wrapper); 5759 frame()->script().windowProxy(world)->updateDocumentWrapper(wrapper);
5760 return wrapper; 5760 return wrapper;
5761 } 5761 }
5762 5762
5763 void Document::trace(Visitor* visitor) 5763 void Document::trace(Visitor* visitor)
5764 { 5764 {
5765 #if ENABLE(OILPAN) 5765 #if ENABLE(OILPAN)
5766 visitor->trace(m_importsController); 5766 visitor->trace(m_importsController);
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
5825 #ifndef NDEBUG 5825 #ifndef NDEBUG
5826 using namespace blink; 5826 using namespace blink;
5827 void showLiveDocumentInstances() 5827 void showLiveDocumentInstances()
5828 { 5828 {
5829 WeakDocumentSet& set = liveDocumentSet(); 5829 WeakDocumentSet& set = liveDocumentSet();
5830 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5830 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5831 for (Document* document : set) 5831 for (Document* document : set)
5832 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data()); 5832 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data());
5833 } 5833 }
5834 #endif 5834 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/DOMTypedArray.cpp ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698