Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: Source/bindings/templates/interface.cpp

Issue 695773002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% extends 'interface_base.cpp' %} 1 {% extends 'interface_base.cpp' %}
2 2
3 3
4 {##############################################################################} 4 {##############################################################################}
5 {% block indexed_property_getter %} 5 {% block indexed_property_getter %}
6 {% if indexed_property_getter and not indexed_property_getter.is_custom %} 6 {% if indexed_property_getter and not indexed_property_getter.is_custom %}
7 {% set getter = indexed_property_getter %} 7 {% set getter = indexed_property_getter %}
8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info) 8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info)
9 { 9 {
10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder()); 10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
(...skipping 950 matching lines...) Expand 10 before | Expand all | Expand 10 after
961 v8::Handle<v8::Object> {{v8_class}}::createWrapper({{pass_cpp_type}} impl, v8::H andle<v8::Object> creationContext, v8::Isolate* isolate) 961 v8::Handle<v8::Object> {{v8_class}}::createWrapper({{pass_cpp_type}} impl, v8::H andle<v8::Object> creationContext, v8::Isolate* isolate)
962 { 962 {
963 ASSERT(impl); 963 ASSERT(impl);
964 ASSERT(!DOMDataStore::containsWrapper<{{v8_class}}>(impl.get(), isolate)); 964 ASSERT(!DOMDataStore::containsWrapper<{{v8_class}}>(impl.get(), isolate));
965 965
966 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , &wrapperTypeInfo, impl->toScriptWrappableBase(), isolate); 966 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , &wrapperTypeInfo, impl->toScriptWrappableBase(), isolate);
967 if (UNLIKELY(wrapper.IsEmpty())) 967 if (UNLIKELY(wrapper.IsEmpty()))
968 return wrapper; 968 return wrapper;
969 969
970 installConditionallyEnabledProperties(wrapper, isolate); 970 installConditionallyEnabledProperties(wrapper, isolate);
971 V8DOMWrapper::associateObjectWithWrapper<{{v8_class}}>(impl, &wrapperTypeInf o, wrapper, isolate); 971 V8DOMWrapper::associateObjectWithWrapper<{{v8_class}}>(isolate, impl, &wrapp erTypeInfo, wrapper);
972 return wrapper; 972 return wrapper;
973 } 973 }
974 974
975 {% endif %} 975 {% endif %}
976 {% endblock %} 976 {% endblock %}
977 977
978 978
979 {##############################################################################} 979 {##############################################################################}
980 {% block deref_object_and_to_v8_no_inline %} 980 {% block deref_object_and_to_v8_no_inline %}
981 void {{v8_class}}::refObject(ScriptWrappableBase* scriptWrappableBase) 981 void {{v8_class}}::refObject(ScriptWrappableBase* scriptWrappableBase)
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
1021 } 1021 }
1022 1022
1023 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %} 1023 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %}
1024 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&)) 1024 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&))
1025 { 1025 {
1026 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method; 1026 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method;
1027 } 1027 }
1028 {% endfor %} 1028 {% endfor %}
1029 {% endif %} 1029 {% endif %}
1030 {% endblock %} 1030 {% endblock %}
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698