Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: Source/core/dom/Node.cpp

Issue 695773002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 2419 matching lines...) Expand 10 before | Expand all | Expand 10 after
2430 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , wrapperType, toScriptWrappableBase(), isolate); 2430 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , wrapperType, toScriptWrappableBase(), isolate);
2431 if (UNLIKELY(wrapper.IsEmpty())) 2431 if (UNLIKELY(wrapper.IsEmpty()))
2432 return wrapper; 2432 return wrapper;
2433 2433
2434 wrapperType->installConditionallyEnabledProperties(wrapper, isolate); 2434 wrapperType->installConditionallyEnabledProperties(wrapper, isolate);
2435 return associateWithWrapper(wrapperType, wrapper, isolate); 2435 return associateWithWrapper(wrapperType, wrapper, isolate);
2436 } 2436 }
2437 2437
2438 v8::Handle<v8::Object> Node::associateWithWrapper(const WrapperTypeInfo* wrapper Type, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate) 2438 v8::Handle<v8::Object> Node::associateWithWrapper(const WrapperTypeInfo* wrapper Type, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate)
2439 { 2439 {
2440 return V8DOMWrapper::associateObjectWithWrapperNonTemplate(this, wrapperType , wrapper, isolate); 2440 return V8DOMWrapper::associateObjectWithWrapperNonTemplate(isolate, this, wr apperType, wrapper);
2441 } 2441 }
2442 2442
2443 } // namespace blink 2443 } // namespace blink
2444 2444
2445 #ifndef NDEBUG 2445 #ifndef NDEBUG
2446 2446
2447 void showNode(const blink::Node* node) 2447 void showNode(const blink::Node* node)
2448 { 2448 {
2449 if (node) 2449 if (node)
2450 node->showNode(""); 2450 node->showNode("");
2451 } 2451 }
2452 2452
2453 void showTree(const blink::Node* node) 2453 void showTree(const blink::Node* node)
2454 { 2454 {
2455 if (node) 2455 if (node)
2456 node->showTreeForThis(); 2456 node->showTreeForThis();
2457 } 2457 }
2458 2458
2459 void showNodePath(const blink::Node* node) 2459 void showNodePath(const blink::Node* node)
2460 { 2460 {
2461 if (node) 2461 if (node)
2462 node->showNodePathForThis(); 2462 node->showNodePathForThis();
2463 } 2463 }
2464 2464
2465 #endif 2465 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698