Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp

Issue 695773002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 RefPtrWillBeRawPtr<MessageChannel> obj = MessageChannel::create(context); 47 RefPtrWillBeRawPtr<MessageChannel> obj = MessageChannel::create(context);
48 48
49 v8::Local<v8::Object> wrapper = info.Holder(); 49 v8::Local<v8::Object> wrapper = info.Holder();
50 50
51 // Create references from the MessageChannel wrapper to the two 51 // Create references from the MessageChannel wrapper to the two
52 // MessagePort wrappers to make sure that the MessagePort wrappers 52 // MessagePort wrappers to make sure that the MessagePort wrappers
53 // stay alive as long as the MessageChannel wrapper is around. 53 // stay alive as long as the MessageChannel wrapper is around.
54 V8HiddenValue::setHiddenValue(info.GetIsolate(), wrapper, V8HiddenValue::por t1(info.GetIsolate()), toV8(obj->port1(), info.Holder(), info.GetIsolate())); 54 V8HiddenValue::setHiddenValue(info.GetIsolate(), wrapper, V8HiddenValue::por t1(info.GetIsolate()), toV8(obj->port1(), info.Holder(), info.GetIsolate()));
55 V8HiddenValue::setHiddenValue(info.GetIsolate(), wrapper, V8HiddenValue::por t2(info.GetIsolate()), toV8(obj->port2(), info.Holder(), info.GetIsolate())); 55 V8HiddenValue::setHiddenValue(info.GetIsolate(), wrapper, V8HiddenValue::por t2(info.GetIsolate()), toV8(obj->port2(), info.Holder(), info.GetIsolate()));
56 56
57 V8DOMWrapper::associateObjectWithWrapper<V8MessageChannel>(obj.release(), &w rapperTypeInfo, wrapper, info.GetIsolate()); 57 V8DOMWrapper::associateObjectWithWrapper<V8MessageChannel>(info.GetIsolate() , obj.release(), &wrapperTypeInfo, wrapper);
58 info.GetReturnValue().Set(wrapper); 58 info.GetReturnValue().Set(wrapper);
59 } 59 }
60 60
61 } // namespace blink 61 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/WorkerScriptController.cpp ('k') | Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698