Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: Source/bindings/core/v8/ScriptWrappable.cpp

Issue 695773002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8DOMWrapper.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "bindings/core/v8/ScriptWrappable.h" 6 #include "bindings/core/v8/ScriptWrappable.h"
7 7
8 #include "bindings/core/v8/DOMDataStore.h" 8 #include "bindings/core/v8/DOMDataStore.h"
9 #include "bindings/core/v8/V8DOMWrapper.h" 9 #include "bindings/core/v8/V8DOMWrapper.h"
10 10
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , wrapperTypeInfo, toScriptWrappableBase(), isolate); 60 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(creationContext , wrapperTypeInfo, toScriptWrappableBase(), isolate);
61 if (UNLIKELY(wrapper.IsEmpty())) 61 if (UNLIKELY(wrapper.IsEmpty()))
62 return wrapper; 62 return wrapper;
63 63
64 wrapperTypeInfo->installConditionallyEnabledProperties(wrapper, isolate); 64 wrapperTypeInfo->installConditionallyEnabledProperties(wrapper, isolate);
65 return associateWithWrapper(wrapperTypeInfo, wrapper, isolate); 65 return associateWithWrapper(wrapperTypeInfo, wrapper, isolate);
66 } 66 }
67 67
68 v8::Handle<v8::Object> ScriptWrappable::associateWithWrapper(const WrapperTypeIn fo* wrapperTypeInfo, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate) 68 v8::Handle<v8::Object> ScriptWrappable::associateWithWrapper(const WrapperTypeIn fo* wrapperTypeInfo, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate)
69 { 69 {
70 return V8DOMWrapper::associateObjectWithWrapperNonTemplate(this, wrapperType Info, wrapper, isolate); 70 return V8DOMWrapper::associateObjectWithWrapperNonTemplate(isolate, this, wr apperTypeInfo, wrapper);
71 } 71 }
72 72
73 } // namespace blink 73 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8DOMWrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698