Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp - Issue 695773002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp

Issue 695773002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/WorkerScriptController.cpp ('k') | Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp b/Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp

index 2ab5b1a06b468e46190045be7a70e31d8c132748..677b03c88e0320b437be761a56f6e5dc9d7fa79b 100644

--- a/Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp

@@ -54,7 +54,7 @@ void V8MessageChannel::constructorCustom(const v8::FunctionCallbackInfo<v8::Valu

V8HiddenValue::setHiddenValue(info.GetIsolate(), wrapper, V8HiddenValue::port1(info.GetIsolate()), toV8(obj->port1(), info.Holder(), info.GetIsolate()));

V8HiddenValue::setHiddenValue(info.GetIsolate(), wrapper, V8HiddenValue::port2(info.GetIsolate()), toV8(obj->port2(), info.Holder(), info.GetIsolate()));

- V8DOMWrapper::associateObjectWithWrapper<V8MessageChannel>(obj.release(), &wrapperTypeInfo, wrapper, info.GetIsolate());

+ V8DOMWrapper::associateObjectWithWrapper<V8MessageChannel>(info.GetIsolate(), obj.release(), &wrapperTypeInfo, wrapper);

info.GetReturnValue().Set(wrapper);

}

« no previous file with comments | « Source/bindings/core/v8/WorkerScriptController.cpp ('k') | Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp » ('j') | no next file with comments »