Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 695663003: Cleanup: Go with SkDebugf instead of GrPrintf. (Closed)

Created:
6 years, 1 month ago by tfarina
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org, robertphillips
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cleanup: Go with SkDebugf instead of GrPrintf. Since GrPrintf is just defined to SkDebugf, we can go with the later directly. BUG=None TEST=None R=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/38406c82b913350e55fa04af8c1941cd9b4aff52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -78 lines) Patch
M experimental/AndroidPathRenderer/GrAndroidPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrConfig.h View 2 chunks +1 line, -7 lines 0 comments Download
M include/gpu/gl/GrGLConfig.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrAtlas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawState.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrGpuFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLExtensions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLUtil.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/views/SkTouchGesture.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tfarina
6 years, 1 month ago (2014-10-30 22:37:52 UTC) #1
bsalomon
lgtm
6 years, 1 month ago (2014-10-31 12:50:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695663003/1
6 years, 1 month ago (2014-10-31 12:59:30 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 14:11:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 38406c82b913350e55fa04af8c1941cd9b4aff52

Powered by Google App Engine
This is Rietveld 408576698