Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 691863002: [DevTools] Remove DevToolsHttpHandler::Stop. (Closed)

Created:
6 years, 1 month ago by vkuzkokov
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, vsevik, extensions-reviews_chromium.org, lcwu+watch_chromium.org, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, gunsch+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, aandrey+blink_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@httpHandler
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove DevToolsHttpHandler::Stop. Use delete instead. BUG=430909 Committed: https://crrev.com/3632399d8611957d8d96106fd5c6f801d7673261 Cr-Commit-Position: refs/heads/master@{#304215}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : #

Patch Set 4 : Rebased #

Patch Set 5 : Rebased #

Patch Set 6 : Rebased #

Patch Set 7 : Rebased #

Patch Set 8 : Rebased #

Total comments: 2

Patch Set 9 : Removed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -75 lines) Patch
M android_webview/native/aw_dev_tools_server.h View 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/native/aw_dev_tools_server.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/android/dev_tools_server.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/dev_tools_server.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/devtools/remote_debugging_server.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/remote_debugging_server.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chromecast/browser/devtools/remote_debugging_server.h View 2 chunks +2 lines, -1 line 0 comments Download
M chromecast/browser/devtools/remote_debugging_server.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -6 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_unittest.cc View 1 2 3 4 5 6 7 4 chunks +9 lines, -9 lines 0 comments Download
M content/public/browser/devtools_http_handler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.cc View 1 2 3 4 5 6 3 chunks +4 lines, -12 lines 0 comments Download
M extensions/shell/browser/shell_browser_main_parts.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_browser_main_parts.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
vkuzkokov
6 years, 1 month ago (2014-10-30 18:20:29 UTC) #2
dgozman
nit: please add full stop to a patch description. lgtm
6 years, 1 month ago (2014-11-13 13:14:36 UTC) #3
mnaganov (inactive)
android_webview/ LGTM
6 years, 1 month ago (2014-11-13 16:08:52 UTC) #5
gunsch
On 2014/11/13 16:08:52, mnaganov (cr) wrote: > android_webview/ LGTM chromecast/ lgtm
6 years, 1 month ago (2014-11-13 17:03:04 UTC) #6
vkuzkokov
PTAL: jam: content/public/browser/devtools_http_handler.h pfeldman: content/shell/browser/shell_browser_main_parts.h content/shell/browser/shell_browser_main_parts.cc jamescook: extensions/shell/browser/shell_browser_main_parts.h extensions/shell/browser/shell_browser_main_parts.cc dtrainor: chrome/browser/android/dev_tools_server.h chrome/browser/android/dev_tools_server.cc
6 years, 1 month ago (2014-11-13 18:48:17 UTC) #8
jam
lgtm https://codereview.chromium.org/691863002/diff/140001/content/public/browser/devtools_http_handler.h File content/public/browser/devtools_http_handler.h (right): https://codereview.chromium.org/691863002/diff/140001/content/public/browser/devtools_http_handler.h#newcode78 content/public/browser/devtools_http_handler.h:78: virtual ~DevToolsHttpHandler() {} nit: perhaps add a comment ...
6 years, 1 month ago (2014-11-13 20:27:40 UTC) #9
James Cook
LGTM with nit https://codereview.chromium.org/691863002/diff/140001/extensions/shell/browser/shell_browser_main_parts.cc File extensions/shell/browser/shell_browser_main_parts.cc (right): https://codereview.chromium.org/691863002/diff/140001/extensions/shell/browser/shell_browser_main_parts.cc#newcode196 extensions/shell/browser/shell_browser_main_parts.cc:196: // CreateHttpHandler retains ownership over DevToolsHttpHandler. ...
6 years, 1 month ago (2014-11-13 20:44:02 UTC) #10
David Trainor- moved to gerrit
chrome/browser/android/ lgtm
6 years, 1 month ago (2014-11-13 21:21:38 UTC) #12
vkuzkokov
Removed comment
6 years, 1 month ago (2014-11-14 12:12:02 UTC) #13
pfeldman
lgtm
6 years, 1 month ago (2014-11-14 13:52:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691863002/160001
6 years, 1 month ago (2014-11-14 13:55:19 UTC) #16
commit-bot: I haz the power
Committed patchset #9 (id:160001)
6 years, 1 month ago (2014-11-14 15:34:13 UTC) #17
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 15:34:54 UTC) #18
Message was sent while issue was closed. 
Patchset 9 (id:??) landed as
https://crrev.com/3632399d8611957d8d96106fd5c6f801d7673261
Cr-Commit-Position: refs/heads/master@{#304215}

Powered by Google App Engine
This is Rietveld 408576698