Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3470)

Unified Diff: content/browser/devtools/devtools_http_handler_impl.cc

Issue 691863002: [DevTools] Remove DevToolsHttpHandler::Stop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@httpHandler
Patch Set: Removed comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler_impl.cc
diff --git a/content/browser/devtools/devtools_http_handler_impl.cc b/content/browser/devtools/devtools_http_handler_impl.cc
index 7c1264432eedc2bc62cd5ed3a865d465db406188..e18e41b6ceb3628d19e647b8be4d1e13e2492b2b 100644
--- a/content/browser/devtools/devtools_http_handler_impl.cc
+++ b/content/browser/devtools/devtools_http_handler_impl.cc
@@ -101,7 +101,6 @@ class DevToolsHttpHandlerImpl : public DevToolsHttpHandler {
private:
// DevToolsHttpHandler implementation.
- void Stop() override;
GURL GetFrontendURL() override;
@@ -542,16 +541,12 @@ DevToolsHttpHandler::ServerSocketFactory::CreateAndListen() const {
// DevToolsHttpHandlerImpl ---------------------------------------------------
DevToolsHttpHandlerImpl::~DevToolsHttpHandlerImpl() {
+ TerminateOnUI(thread_, server_wrapper_);
STLDeleteValues(&target_map_);
STLDeleteValues(&browser_targets_);
STLDeleteValues(&connection_to_client_);
}
-void DevToolsHttpHandlerImpl::Stop() {
- TerminateOnUI(thread_, server_wrapper_);
- delete this;
-}
-
GURL DevToolsHttpHandlerImpl::GetFrontendURL() {
if (!server_ip_address_)
return GURL();
« no previous file with comments | « chromecast/browser/devtools/remote_debugging_server.cc ('k') | content/browser/devtools/devtools_http_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698