chrome/browser/devtools/remote_debugging_server.cc - Issue 691863002: [DevTools] Remove DevToolsHttpHandler::Stop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/remote_debugging_server.cc

Issue 691863002: [DevTools] Remove DevToolsHttpHandler::Stop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@httpHandler

Patch Set: Removed comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/remote_debugging_server.cc

diff --git a/chrome/browser/devtools/remote_debugging_server.cc b/chrome/browser/devtools/remote_debugging_server.cc

index 3c7fd595063e3ef9b5336228862cfea7950e3ca0..9a0b4b92e6828fec93430da6f6805726ab5507ff 100644

--- a/chrome/browser/devtools/remote_debugging_server.cc

+++ b/chrome/browser/devtools/remote_debugging_server.cc

@@ -47,13 +47,12 @@ RemoteDebuggingServer::RemoteDebuggingServer(

scoped_ptr<content::DevToolsHttpHandler::ServerSocketFactory> factory(

new TCPServerSocketFactory(ip, port, 1));

- devtools_http_handler_ = content::DevToolsHttpHandler::Start(

+ devtools_http_handler_.reset(content::DevToolsHttpHandler::Start(

factory.Pass(),

"",

new BrowserListTabContentsProvider(host_desktop_type),

- output_dir);

+ output_dir));

}

RemoteDebuggingServer::~RemoteDebuggingServer() {

- devtools_http_handler_->Stop();

}