Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Side by Side Diff: content/public/browser/devtools_http_handler.h

Issue 691863002: [DevTools] Remove DevToolsHttpHandler::Stop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@httpHandler
Patch Set: Rebased Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_HTTP_HANDLER_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_HTTP_HANDLER_H_
6 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_HTTP_HANDLER_H_ 6 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_HTTP_HANDLER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 // If |active_port_output_directory| is non-empty, it is assumed the 65 // If |active_port_output_directory| is non-empty, it is assumed the
66 // socket_factory was initialized with an ephemeral port (0). The 66 // socket_factory was initialized with an ephemeral port (0). The
67 // port selected by the OS will be written to a well-known file in 67 // port selected by the OS will be written to a well-known file in
68 // the output directory. 68 // the output directory.
69 CONTENT_EXPORT static DevToolsHttpHandler* Start( 69 CONTENT_EXPORT static DevToolsHttpHandler* Start(
70 scoped_ptr<ServerSocketFactory> server_socket_factory, 70 scoped_ptr<ServerSocketFactory> server_socket_factory,
71 const std::string& frontend_url, 71 const std::string& frontend_url,
72 DevToolsHttpHandlerDelegate* delegate, 72 DevToolsHttpHandlerDelegate* delegate,
73 const base::FilePath& active_port_output_directory); 73 const base::FilePath& active_port_output_directory);
74 74
75 // Called from the main thread in order to stop protocol handler.
76 // Automatically destroys the handler instance.
77 virtual void Stop() = 0;
78
79 // Returns the URL for the address to debug |agent_host|. 75 // Returns the URL for the address to debug |agent_host|.
80 virtual GURL GetFrontendURL() = 0; 76 virtual GURL GetFrontendURL() = 0;
81 77
82 protected:
83 virtual ~DevToolsHttpHandler() {} 78 virtual ~DevToolsHttpHandler() {}
jam 2014/11/13 20:27:40 nit: perhaps add a comment that deleting this obje
84 }; 79 };
85 80
86 } // namespace content 81 } // namespace content
87 82
88 #endif // CONTENT_PUBLIC_BROWSER_DEVTOOLS_HTTP_HANDLER_H_ 83 #endif // CONTENT_PUBLIC_BROWSER_DEVTOOLS_HTTP_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698