[DevTools] Remove DevToolsHttpHandler::Stop.

extensions/shell/browser/shell_browser_main_parts.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/shell/browser/shell_browser_main_parts.h"
 
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "components/omaha_query_params/omaha_query_params.h"
@@ skipping 175 matching lines @@
   std::string install_crx_id =
       cmd->GetSwitchValueASCII(switches::kAppShellInstallCrx);
   if (install_crx_id.size() != 0) {
     CHECK(install_crx_id.size() == 32)
         << "Extension ID must be exactly 32 characters long.";
     UpdateService* update_service = UpdateService::Get(browser_context_.get());
     update_service->DownloadAndInstall(install_crx_id,
                                        base::Bind(CrxInstallComplete));
   }
 
   // CreateHttpHandler retains ownership over DevToolsHttpHandler.

[James Cook, 2014/11/13 20:44:01]

nit: This comment is wrong. You can just delete it if you like.

-  devtools_http_handler_ =
+  devtools_http_handler_.reset(
       content::ShellDevToolsManagerDelegate::CreateHttpHandler(
-          browser_context_.get());
+          browser_context_.get()));
   if (parameters_.ui_task) {
     // For running browser tests.
     parameters_.ui_task->Run();
     delete parameters_.ui_task;
     run_message_loop_ = false;
   } else {
     browser_main_delegate_->Start(browser_context_.get());
   }
 }
 
 bool ShellBrowserMainParts::MainMessageLoopRun(int* result_code) {
   if (!run_message_loop_)
     return true;
   // TODO(yoz): just return false here?
   base::RunLoop run_loop;
   run_loop.Run();
   *result_code = content::RESULT_CODE_NORMAL_EXIT;
   return true;
 }
 
 void ShellBrowserMainParts::PostMainMessageLoopRun() {
   browser_main_delegate_->Shutdown();
-  if (devtools_http_handler_) {
-    // Note that Stop destroys devtools_http_handler_.
-    devtools_http_handler_->Stop();
-    devtools_http_handler_ = nullptr;
-  }
+  devtools_http_handler_.reset();
 
 #if !defined(DISABLE_NACL)
   task_tracker_.TryCancelAll();
   nacl::NaClBrowser::SetDelegate(nullptr);
 #endif
 
   oauth2_token_service_.reset();
   BrowserContextDependencyManager::GetInstance()->DestroyBrowserContextServices(
       browser_context_.get());
   extension_system_ = NULL;
@@ skipping 17 matching lines @@
 }
 
 void ShellBrowserMainParts::CreateExtensionSystem() {
   DCHECK(browser_context_);
   extension_system_ = static_cast<ShellExtensionSystem*>(
       ExtensionSystem::Get(browser_context_.get()));
   extension_system_->InitForRegularProfile(true);
 }
 
 }  // namespace extensions