Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: extensions/shell/browser/shell_browser_main_parts.cc

Issue 691863002: [DevTools] Remove DevToolsHttpHandler::Stop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@httpHandler
Patch Set: Removed comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/shell/browser/shell_browser_main_parts.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/browser/shell_browser_main_parts.cc
diff --git a/extensions/shell/browser/shell_browser_main_parts.cc b/extensions/shell/browser/shell_browser_main_parts.cc
index f376cbc020a71d777977d145999331b9a180da65..a835f616929af2a37218b1bdda7d348d7719452f 100644
--- a/extensions/shell/browser/shell_browser_main_parts.cc
+++ b/extensions/shell/browser/shell_browser_main_parts.cc
@@ -193,10 +193,9 @@ void ShellBrowserMainParts::PreMainMessageLoopRun() {
base::Bind(CrxInstallComplete));
}
- // CreateHttpHandler retains ownership over DevToolsHttpHandler.
- devtools_http_handler_ =
+ devtools_http_handler_.reset(
content::ShellDevToolsManagerDelegate::CreateHttpHandler(
- browser_context_.get());
+ browser_context_.get()));
if (parameters_.ui_task) {
// For running browser tests.
parameters_.ui_task->Run();
@@ -219,11 +218,7 @@ bool ShellBrowserMainParts::MainMessageLoopRun(int* result_code) {
void ShellBrowserMainParts::PostMainMessageLoopRun() {
browser_main_delegate_->Shutdown();
- if (devtools_http_handler_) {
- // Note that Stop destroys devtools_http_handler_.
- devtools_http_handler_->Stop();
- devtools_http_handler_ = nullptr;
- }
+ devtools_http_handler_.reset();
#if !defined(DISABLE_NACL)
task_tracker_.TryCancelAll();
« no previous file with comments | « extensions/shell/browser/shell_browser_main_parts.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698