Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: chromecast/browser/devtools/remote_debugging_server.cc

Issue 691863002: [DevTools] Remove DevToolsHttpHandler::Stop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@httpHandler
Patch Set: Removed comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/devtools/remote_debugging_server.cc
diff --git a/chromecast/browser/devtools/remote_debugging_server.cc b/chromecast/browser/devtools/remote_debugging_server.cc
index e0abdc072d809f1ad95240596c0aebf611e41328..9b2bfc5097730a2ff70c4a77dd927f9597c6f023 100644
--- a/chromecast/browser/devtools/remote_debugging_server.cc
+++ b/chromecast/browser/devtools/remote_debugging_server.cc
@@ -129,18 +129,16 @@ void RemoteDebuggingServer::OnPortChanged() {
if (devtools_http_handler_) {
LOG(INFO) << "Stop old devtools: port=" << port_;
- // Note: Stop destroys devtools_http_handler_.
- devtools_http_handler_->Stop();
- devtools_http_handler_ = NULL;
+ devtools_http_handler_.reset();
}
port_ = new_port;
if (port_ > 0) {
- devtools_http_handler_ = content::DevToolsHttpHandler::Start(
+ devtools_http_handler_.reset(content::DevToolsHttpHandler::Start(
CreateSocketFactory(port_),
GetFrontendUrl(),
new CastDevToolsDelegate(),
- base::FilePath());
+ base::FilePath()));
LOG(INFO) << "Devtools started: port=" << port_;
}
}
« no previous file with comments | « chromecast/browser/devtools/remote_debugging_server.h ('k') | content/browser/devtools/devtools_http_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698