Remove the OnError method from notification delegates.

Remove the OnError method from notification delegates.

OnError was meant to support the "onerror" event for Web Notifications,
but it has no call sites. There are a few future use-cases for this event,
but those don't concern non-Web Notifications so we don't need this plumbing.

BUG=428370
Committed: https://crrev.com/212db6946282a49e675fc604f23e1fe101fcd540
Cr-Commit-Position: refs/heads/master@{#302248}

[Peter Beverloo, 2014-10-29 17:00:15]

peter@chromium.org changed reviewers:
+ dewittj@chromium.org, mukai@chromium.org

[Peter Beverloo, 2014-10-29 17:00:17]

Justin, Jun: I'd like your LGTM before sending this out for (much) broader
review. PTAL?

[dewittj, 2014-10-29 17:11:19]

lgtm, thanks for code slaying

https://codereview.chromium.org/687183004/diff/1/chrome/browser/chromeos/net/...
File chrome/browser/chromeos/net/network_portal_notification_controller.cc
(left):

https://codereview.chromium.org/687183004/diff/1/chrome/browser/chromeos/net/...
chrome/browser/chromeos/net/network_portal_notification_controller.cc:81:
NetworkPortalNotificationController::NOTIFICATION_METRIC_COUNT);
Is there a metric that needs to be updated/deprecated as well?

[Peter Beverloo, 2014-10-29 17:24:48]

On 2014/10/29 17:11:19, dewittj wrote:
> lgtm, thanks for code slaying
> 
>
https://codereview.chromium.org/687183004/diff/1/chrome/browser/chromeos/net/...
> File chrome/browser/chromeos/net/network_portal_notification_controller.cc
> (left):
> 
>
https://codereview.chromium.org/687183004/diff/1/chrome/browser/chromeos/net/...
> chrome/browser/chromeos/net/network_portal_notification_controller.cc:81:
> NetworkPortalNotificationController::NOTIFICATION_METRIC_COUNT);
> Is there a metric that needs to be updated/deprecated as well?

Since it's a metric we can't safely remove it because data would be mixed up.
It's not explicitly noted in histograms.xml, nor does the UMA dashboard say
anything other than UNKNOWN.

[Peter Beverloo, 2014-10-29 20:02:59]

peter@chromium.org changed reviewers:
+ nasko@chromium.org, stevenjb@chromium.org, thestig@chromium.org

[Peter Beverloo, 2014-10-29 20:03:00]

+stevenjb for ash/system/
+thestig for chrome/
+nasko for content/

[stevenjb, 2014-10-29 20:05:19]

ash/system lgtm

[nasko, 2014-10-29 21:29:41]

content/ LGTM

[Lei Zhang, 2014-10-29 22:19:26]

chrome/ lgtm!

https://codereview.chromium.org/687183004/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/net/network_portal_notification_controller.cc
(left):

https://codereview.chromium.org/687183004/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/net/network_portal_notification_controller.cc:80:
NetworkPortalNotificationController::NOTIFICATION_METRIC_ERROR,
NotificationMetric is useless with this removal. Add a TODO to remove it and
associated UMA code in a future CL?

[Peter Beverloo, 2014-10-30 15:02:07]

Thanks for the reviews! I'll land this after 684253002 lands (already rebased on
top of that).

https://codereview.chromium.org/687183004/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/net/network_portal_notification_controller.cc
(left):

https://codereview.chromium.org/687183004/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/net/network_portal_notification_controller.cc:80:
NetworkPortalNotificationController::NOTIFICATION_METRIC_ERROR,
On 2014/10/29 22:19:25, Lei Zhang wrote:
> NotificationMetric is useless with this removal. Add a TODO to remove it and
> associated UMA code in a future CL?

Done. I presume you mean NOTIFICATION_METRIC_ERROR, which is what I've added a
TODO for.

[Lei Zhang, 2014-10-30 19:18:46]

https://codereview.chromium.org/687183004/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/net/network_portal_notification_controller.cc
(left):

https://codereview.chromium.org/687183004/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/net/network_portal_notification_controller.cc:80:
NetworkPortalNotificationController::NOTIFICATION_METRIC_ERROR,
On 2014/10/30 15:02:07, Peter Beverloo wrote:
> On 2014/10/29 22:19:25, Lei Zhang wrote:
> > NotificationMetric is useless with this removal. Add a TODO to remove it and
> > associated UMA code in a future CL?
> 
> Done. I presume you mean NOTIFICATION_METRIC_ERROR, which is what I've added a
> TODO for.

Err, yes. :)

[Peter Beverloo, 2014-10-31 10:09:49]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2014-10-31 10:11:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/687183004/80001

[commit-bot: I haz the power, 2014-10-31 10:21:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-31 10:21:50]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Peter Beverloo, 2014-10-31 10:28:32]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2014-10-31 10:28:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/687183004/120001

[commit-bot: I haz the power, 2014-10-31 11:18:59]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2014-10-31 11:19:32]

Patchset 7 (id:??) landed as
https://crrev.com/212db6946282a49e675fc604f23e1fe101fcd540
Cr-Commit-Position: refs/heads/master@{#302248}