Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Unified Diff: content/browser/notifications/page_notification_delegate.cc

Issue 687183004: Remove the OnError method from notification delegates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/notifications/page_notification_delegate.cc
diff --git a/content/browser/notifications/page_notification_delegate.cc b/content/browser/notifications/page_notification_delegate.cc
index e7af1a4ae509aecf094775ca55a8523b1e980437..dacfffbfd22da5db3bdede2ead526dd7b294d480 100644
--- a/content/browser/notifications/page_notification_delegate.cc
+++ b/content/browser/notifications/page_notification_delegate.cc
@@ -26,14 +26,6 @@ void PageNotificationDelegate::NotificationDisplayed() {
sender->Send(new PlatformNotificationMsg_DidShow(notification_id_));
}
-void PageNotificationDelegate::NotificationError() {
- RenderProcessHost* sender = RenderProcessHost::FromID(render_process_id_);
- if (!sender)
- return;
-
- sender->Send(new PlatformNotificationMsg_DidError(notification_id_));
-}
-
// TODO(peter): Remove |by_user| since we're not using that anywhere.
void PageNotificationDelegate::NotificationClosed(bool by_user) {
RenderProcessHost* sender = RenderProcessHost::FromID(render_process_id_);
« no previous file with comments | « content/browser/notifications/page_notification_delegate.h ('k') | content/child/notifications/notification_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698