chrome/browser/notifications/notification_test_util.h - Issue 687183004: Remove the OnError method from notification delegates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_test_util.h

Issue 687183004: Remove the OnError method from notification delegates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_object_proxy.cc ('k') | chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_test_util.h

diff --git a/chrome/browser/notifications/notification_test_util.h b/chrome/browser/notifications/notification_test_util.h

index 1ad1b76a5b629999831c43f7a24a0070aa5bee6a..9b308f736539c21f9c6874d67563694874e62906 100644

--- a/chrome/browser/notifications/notification_test_util.h

+++ b/chrome/browser/notifications/notification_test_util.h

@@ -47,9 +47,6 @@ class LoggingNotificationDelegate : public NotificationDelegate {

virtual void Display() override {

Logger::log("notification displayed\n");

}

- virtual void Error() override {

- Logger::log("notification error\n");

- }

virtual void Click() override {

Logger::log("notification clicked\n");

}