Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1581)

Unified Diff: content/renderer/notification_provider.cc

Issue 687183004: Remove the OnError method from notification delegates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/notification_provider.h ('k') | ui/message_center/notification.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/notification_provider.cc
diff --git a/content/renderer/notification_provider.cc b/content/renderer/notification_provider.cc
index 3c2a3c6e4e7c6106faf51a8aaa828a5b9e23b260..b5e749386cceeaa2b9b9e6d7cc32e0d79b095d40 100644
--- a/content/renderer/notification_provider.cc
+++ b/content/renderer/notification_provider.cc
@@ -118,7 +118,6 @@ bool NotificationProvider::OnMessageReceived(const IPC::Message& message) {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(NotificationProvider, message)
IPC_MESSAGE_HANDLER(DesktopNotificationMsg_PostDisplay, OnDisplay);
- IPC_MESSAGE_HANDLER(DesktopNotificationMsg_PostError, OnError);
IPC_MESSAGE_HANDLER(DesktopNotificationMsg_PostClose, OnClose);
IPC_MESSAGE_HANDLER(DesktopNotificationMsg_PostClick, OnClick);
IPC_MESSAGE_UNHANDLED(handled = false)
@@ -139,15 +138,6 @@ void NotificationProvider::OnDisplay(int id) {
notification.dispatchDisplayEvent();
}
-void NotificationProvider::OnError(int id) {
- WebNotification notification;
- bool found = manager_.GetNotification(id, &notification);
- // |found| may be false if the WebNotification went out of scope in
- // the page before the error occurred.
- if (found)
- notification.dispatchErrorEvent(WebString());
-}
-
void NotificationProvider::OnClose(int id, bool by_user) {
WebNotification notification;
bool found = manager_.GetNotification(id, &notification);
« no previous file with comments | « content/renderer/notification_provider.h ('k') | ui/message_center/notification.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698