Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: content/renderer/notification_provider.h

Issue 687183004: Remove the OnError method from notification delegates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_NOTIFICATION_PROVIDER_H_ 5 #ifndef CONTENT_RENDERER_NOTIFICATION_PROVIDER_H_
6 #define CONTENT_RENDERER_NOTIFICATION_PROVIDER_H_ 6 #define CONTENT_RENDERER_NOTIFICATION_PROVIDER_H_
7 7
8 #include "base/memory/scoped_vector.h" 8 #include "base/memory/scoped_vector.h"
9 #include "content/public/renderer/render_frame_observer.h" 9 #include "content/public/renderer/render_frame_observer.h"
10 #include "content/renderer/active_notification_tracker.h" 10 #include "content/renderer/active_notification_tracker.h"
(...skipping 28 matching lines...) Expand all
39 // Sends an IPC to the browser process to display the notification identified 39 // Sends an IPC to the browser process to display the notification identified
40 // by |notification|, accompanied by the downloaded icon. 40 // by |notification|, accompanied by the downloaded icon.
41 void DisplayNotification(int notification_id, const SkBitmap& icon); 41 void DisplayNotification(int notification_id, const SkBitmap& icon);
42 42
43 // Removes the IconDownload object associated with |notification_id|, stopping 43 // Removes the IconDownload object associated with |notification_id|, stopping
44 // any in-progress download. Returns whether the notification was removed. 44 // any in-progress download. Returns whether the notification was removed.
45 bool RemovePendingNotification(int notification_id); 45 bool RemovePendingNotification(int notification_id);
46 46
47 // IPC handlers. 47 // IPC handlers.
48 void OnDisplay(int id); 48 void OnDisplay(int id);
49 void OnError(int id);
50 void OnClose(int id, bool by_user); 49 void OnClose(int id, bool by_user);
51 void OnClick(int id); 50 void OnClick(int id);
52 void OnNavigate(); 51 void OnNavigate();
53 52
54 // A vector tracking notifications whose icon is still being downloaded. 53 // A vector tracking notifications whose icon is still being downloaded.
55 typedef ScopedVector<NotificationIconLoader> PendingNotifications; 54 typedef ScopedVector<NotificationIconLoader> PendingNotifications;
56 PendingNotifications pending_notifications_; 55 PendingNotifications pending_notifications_;
57 56
58 // A tracker object which manages the active notifications and the IDs 57 // A tracker object which manages the active notifications and the IDs
59 // that are used to refer to them over IPC. 58 // that are used to refer to them over IPC.
60 ActiveNotificationTracker manager_; 59 ActiveNotificationTracker manager_;
61 60
62 DISALLOW_COPY_AND_ASSIGN(NotificationProvider); 61 DISALLOW_COPY_AND_ASSIGN(NotificationProvider);
63 }; 62 };
64 63
65 } // namespace content 64 } // namespace content
66 65
67 #endif // CONTENT_RENDERER_NOTIFICATION_PROVIDER_H_ 66 #endif // CONTENT_RENDERER_NOTIFICATION_PROVIDER_H_
OLDNEW
« no previous file with comments | « content/public/browser/desktop_notification_delegate.h ('k') | content/renderer/notification_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698