Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: chrome/browser/chromeos/net/network_portal_notification_controller.cc

Issue 687183004: Remove the OnError method from notification delegates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/net/network_portal_notification_controller.cc
diff --git a/chrome/browser/chromeos/net/network_portal_notification_controller.cc b/chrome/browser/chromeos/net/network_portal_notification_controller.cc
index 897511fc6d0c0edb5c5878ebd4fa1b283228e828..17ad3559ba1da68cc749bb1557051dd739856ecd 100644
--- a/chrome/browser/chromeos/net/network_portal_notification_controller.cc
+++ b/chrome/browser/chromeos/net/network_portal_notification_controller.cc
@@ -55,7 +55,6 @@ class NetworkPortalNotificationControllerDelegate
// Overridden from message_center::NotificationDelegate:
virtual void Display() override;
- virtual void Error() override;
virtual void Close(bool by_user) override;
virtual void Click() override;
@@ -74,13 +73,6 @@ void NetworkPortalNotificationControllerDelegate::Display() {
NetworkPortalNotificationController::NOTIFICATION_METRIC_COUNT);
}
-void NetworkPortalNotificationControllerDelegate::Error() {
- UMA_HISTOGRAM_ENUMERATION(
- NetworkPortalNotificationController::kNotificationMetric,
- NetworkPortalNotificationController::NOTIFICATION_METRIC_ERROR,
- NetworkPortalNotificationController::NOTIFICATION_METRIC_COUNT);
-}
-
void NetworkPortalNotificationControllerDelegate::Close(bool by_user) {
if (clicked_)
return;

Powered by Google App Engine
This is Rietveld 408576698