Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: chrome/browser/chromeos/net/network_portal_notification_controller.h

Issue 687183004: Remove the OnError method from notification delegates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_NET_NETWORK_PORTAL_NOTIFICATION_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_NET_NETWORK_PORTAL_NOTIFICATION_CONTROLLER_H_
6 #define CHROME_BROWSER_CHROMEOS_NET_NETWORK_PORTAL_NOTIFICATION_CONTROLLER_H_ 6 #define CHROME_BROWSER_CHROMEOS_NET_NETWORK_PORTAL_NOTIFICATION_CONTROLLER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "chromeos/network/portal_detector/network_portal_detector.h" 11 #include "chromeos/network/portal_detector/network_portal_detector.h"
12 12
13 namespace chromeos { 13 namespace chromeos {
14 14
15 class NetworkState; 15 class NetworkState;
16 16
17 class NetworkPortalNotificationController { 17 class NetworkPortalNotificationController {
18 public: 18 public:
19 enum NotificationMetric { 19 enum NotificationMetric {
20 NOTIFICATION_METRIC_DISPLAYED = 0, 20 NOTIFICATION_METRIC_DISPLAYED = 0,
21 // TODO(peter): The ERROR metric is not being used anymore, remove it.
21 NOTIFICATION_METRIC_ERROR, 22 NOTIFICATION_METRIC_ERROR,
22 NOTIFICATION_METRIC_COUNT 23 NOTIFICATION_METRIC_COUNT
23 }; 24 };
24 25
25 enum UserActionMetric { 26 enum UserActionMetric {
26 USER_ACTION_METRIC_CLICKED, 27 USER_ACTION_METRIC_CLICKED,
27 USER_ACTION_METRIC_CLOSED, 28 USER_ACTION_METRIC_CLOSED,
28 USER_ACTION_METRIC_IGNORED, 29 USER_ACTION_METRIC_IGNORED,
29 USER_ACTION_METRIC_COUNT 30 USER_ACTION_METRIC_COUNT
30 }; 31 };
(...skipping 13 matching lines...) Expand all
44 private: 45 private:
45 // Last network path for which notification was displayed. 46 // Last network path for which notification was displayed.
46 std::string last_network_path_; 47 std::string last_network_path_;
47 48
48 DISALLOW_COPY_AND_ASSIGN(NetworkPortalNotificationController); 49 DISALLOW_COPY_AND_ASSIGN(NetworkPortalNotificationController);
49 }; 50 };
50 51
51 } // namespace chromeos 52 } // namespace chromeos
52 53
53 #endif // CHROME_BROWSER_CHROMEOS_NET_NETWORK_PORTAL_NOTIFICATION_CONTROLLER_H_ 54 #endif // CHROME_BROWSER_CHROMEOS_NET_NETWORK_PORTAL_NOTIFICATION_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698