Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 684083002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed)

Created:
6 years, 1 month ago by RAGHURAM
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings (Ref: binding-methods changed: static v8::Handle<v8::Value> createGeneralError(const String&, v8::Isolate*) static v8::Handle<v8::Value> throwGeneralError(const String&, v8::Isolate*)) BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M Source/bindings/core/v8/NPV8Object.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8NPObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8ThrowException.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8ThrowException.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/WorkerScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
RAGHURAM
Please Review. Thanks & Regards
6 years, 1 month ago (2014-10-29 06:51:40 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-10-29 07:09:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684083002/1
6 years, 1 month ago (2014-10-29 07:19:01 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 08:49:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184574

Powered by Google App Engine
This is Rietveld 408576698