Source/bindings/core/v8/WorkerScriptController.cpp - Issue 684083002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/WorkerScriptController.cpp

Issue 684083002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/WorkerScriptController.cpp

diff --git a/Source/bindings/core/v8/WorkerScriptController.cpp b/Source/bindings/core/v8/WorkerScriptController.cpp

index 1efa472cd40deb1c8583e573d8970247c4b83923..141ade6df9b2ae1fb2074327d31ac852641cd8a1 100644

--- a/Source/bindings/core/v8/WorkerScriptController.cpp

+++ b/Source/bindings/core/v8/WorkerScriptController.cpp

@@ -310,7 +310,7 @@ void WorkerScriptController::rethrowExceptionFromImportedScript(PassRefPtrWillBe

const String& errorMessage = errorEvent->message();

if (m_globalScopeExecutionState)

m_globalScopeExecutionState->m_errorEventFromImportedScript = errorEvent;

- exceptionState.rethrowV8Exception(V8ThrowException::createGeneralError(errorMessage, m_isolate));

+ exceptionState.rethrowV8Exception(V8ThrowException::createGeneralError(m_isolate, errorMessage));

}

} // namespace blink

« no previous file with comments | « Source/bindings/core/v8/V8ThrowException.cpp ('k') | no next file » | no next file with comments »