Source/bindings/core/v8/WorkerScriptController.cpp - Issue 684083002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/core/v8/WorkerScriptController.cpp

Issue 684083002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/bindings/core/v8/V8ThrowException.cpp ('k') | no next file » | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 292 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
303 void WorkerScriptController::disableEval(const String& errorMessage)	303 void WorkerScriptController::disableEval(const String& errorMessage)

304 {	304 {

305 m_disableEvalPending = errorMessage;	305 m_disableEvalPending = errorMessage;

306 }	306 }

307	307

308 void WorkerScriptController::rethrowExceptionFromImportedScript(PassRefPtrWillBe RawPtr<ErrorEvent> errorEvent, ExceptionState& exceptionState)	308 void WorkerScriptController::rethrowExceptionFromImportedScript(PassRefPtrWillBe RawPtr<ErrorEvent> errorEvent, ExceptionState& exceptionState)

309 {	309 {

310 const String& errorMessage = errorEvent->message();	310 const String& errorMessage = errorEvent->message();

311 if (m_globalScopeExecutionState)	311 if (m_globalScopeExecutionState)

312 m_globalScopeExecutionState->m_errorEventFromImportedScript = errorEvent ;	312 m_globalScopeExecutionState->m_errorEventFromImportedScript = errorEvent ;

313 exceptionState.rethrowV8Exception(V8ThrowException::createGeneralError(error Message, m_isolate));	313 exceptionState.rethrowV8Exception(V8ThrowException::createGeneralError(m_iso late, errorMessage));

314 }	314 }

315	315

316 } // namespace blink	316 } // namespace blink

OLD	NEW