Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: Source/bindings/core/v8/V8ThrowException.cpp

Issue 684083002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8ThrowException.h ('k') | Source/bindings/core/v8/WorkerScriptController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8ThrowException.cpp
diff --git a/Source/bindings/core/v8/V8ThrowException.cpp b/Source/bindings/core/v8/V8ThrowException.cpp
index 92b4fc7e34d6b4594e8f9d7cbdf47b79dfb8539a..83250757babdbafcbe77edd6edd323da3f3ca308 100644
--- a/Source/bindings/core/v8/V8ThrowException.cpp
+++ b/Source/bindings/core/v8/V8ThrowException.cpp
@@ -52,7 +52,7 @@ v8::Handle<v8::Value> V8ThrowException::createDOMException(int ec, const String&
ASSERT(ec == SecurityError || unsanitizedMessage.isEmpty());
if (ec == V8GeneralError)
- return V8ThrowException::createGeneralError(sanitizedMessage, isolate);
+ return V8ThrowException::createGeneralError(isolate, sanitizedMessage);
if (ec == V8TypeError)
return V8ThrowException::createTypeError(sanitizedMessage, isolate);
if (ec == V8RangeError)
@@ -88,14 +88,14 @@ v8::Handle<v8::Value> V8ThrowException::throwDOMException(int ec, const String&
return V8ThrowException::throwException(exception, isolate);
}
-v8::Handle<v8::Value> V8ThrowException::createGeneralError(const String& message, v8::Isolate* isolate)
+v8::Handle<v8::Value> V8ThrowException::createGeneralError(v8::Isolate* isolate, const String& message)
{
return v8::Exception::Error(v8String(isolate, message.isNull() ? "Error" : message));
}
-v8::Handle<v8::Value> V8ThrowException::throwGeneralError(const String& message, v8::Isolate* isolate)
+v8::Handle<v8::Value> V8ThrowException::throwGeneralError(v8::Isolate* isolate, const String& message)
{
- v8::Handle<v8::Value> exception = V8ThrowException::createGeneralError(message, isolate);
+ v8::Handle<v8::Value> exception = V8ThrowException::createGeneralError(isolate, message);
return V8ThrowException::throwException(exception, isolate);
}
« no previous file with comments | « Source/bindings/core/v8/V8ThrowException.h ('k') | Source/bindings/core/v8/WorkerScriptController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698