Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: Source/bindings/core/v8/NPV8Object.cpp

Issue 684083002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8NPObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/NPV8Object.cpp
diff --git a/Source/bindings/core/v8/NPV8Object.cpp b/Source/bindings/core/v8/NPV8Object.cpp
index 36593b4f5bf92f19cc8f400bfd12b40bf81491ef..152b37aaf5fff167f2c7f7ea74994d0a1c219efe 100644
--- a/Source/bindings/core/v8/NPV8Object.cpp
+++ b/Source/bindings/core/v8/NPV8Object.cpp
@@ -511,7 +511,7 @@ void _NPN_SetException(NPObject* npObject, const NPUTF8 *message)
if (!npObject || !npObjectToV8NPObject(npObject)) {
// We won't be able to find a proper scope for this exception, so just throw it.
// This is consistent with JSC, which throws a global exception all the time.
- V8ThrowException::throwGeneralError(message, v8::Isolate::GetCurrent());
+ V8ThrowException::throwGeneralError(v8::Isolate::GetCurrent(), message);
return;
}
@@ -523,7 +523,7 @@ void _NPN_SetException(NPObject* npObject, const NPUTF8 *message)
ScriptState::Scope scope(scriptState);
ExceptionCatcher exceptionCatcher;
- V8ThrowException::throwGeneralError(message, isolate);
+ V8ThrowException::throwGeneralError(isolate, message);
}
bool _NPN_Enumerate(NPP npp, NPObject* npObject, NPIdentifier** identifier, uint32_t* count)
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8NPObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698