Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: Source/bindings/core/v8/V8ThrowException.h

Issue 684083002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8NPObject.cpp ('k') | Source/bindings/core/v8/V8ThrowException.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8ThrowException.h
diff --git a/Source/bindings/core/v8/V8ThrowException.h b/Source/bindings/core/v8/V8ThrowException.h
index bf760c02c23b431a90787b4cab89e7d9cfed8f12..23f5cebb1c0d8c85ce1961fd52dd930e2d6f773a 100644
--- a/Source/bindings/core/v8/V8ThrowException.h
+++ b/Source/bindings/core/v8/V8ThrowException.h
@@ -47,8 +47,8 @@ public:
static v8::Handle<v8::Value> throwException(v8::Handle<v8::Value>, v8::Isolate*);
- static v8::Handle<v8::Value> createGeneralError(const String&, v8::Isolate*);
- static v8::Handle<v8::Value> throwGeneralError(const String&, v8::Isolate*);
+ static v8::Handle<v8::Value> createGeneralError(v8::Isolate*, const String&);
+ static v8::Handle<v8::Value> throwGeneralError(v8::Isolate*, const String&);
static v8::Handle<v8::Value> createTypeError(const String&, v8::Isolate*);
static v8::Handle<v8::Value> throwTypeError(const String&, v8::Isolate*);
static v8::Handle<v8::Value> createRangeError(const String&, v8::Isolate*);
« no previous file with comments | « Source/bindings/core/v8/V8NPObject.cpp ('k') | Source/bindings/core/v8/V8ThrowException.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698