Source/bindings/core/v8/V8NPObject.cpp - Issue 684083002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8NPObject.cpp

Issue 684083002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8NPObject.cpp

diff --git a/Source/bindings/core/v8/V8NPObject.cpp b/Source/bindings/core/v8/V8NPObject.cpp

index 25173cd8a33c66c26e04d5e025fcca7f08cdf7ca..76c39986bd4aa172d1edae5a7244aab7e91bafbf 100644

--- a/Source/bindings/core/v8/V8NPObject.cpp

+++ b/Source/bindings/core/v8/V8NPObject.cpp

@@ -136,7 +136,7 @@ static void npObjectInvokeImpl(const v8::FunctionCallbackInfo<v8::Value>& info,

}

if (!retval)

- V8ThrowException::throwGeneralError("Error calling method on NPObject.", isolate);

+ V8ThrowException::throwGeneralError(isolate, "Error calling method on NPObject.");

for (int i = 0; i < numArgs; i++)

_NPN_ReleaseVariantValue(&npArgs[i]);

« no previous file with comments | « Source/bindings/core/v8/NPV8Object.cpp ('k') | Source/bindings/core/v8/V8ThrowException.h » ('j') | no next file with comments »