Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 678073005: Patch to remove constant attributes (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : working #

Patch Set 3 : trivial clean up #

Total comments: 1

Patch Set 4 : feedback inc #

Patch Set 5 : #

Patch Set 6 : adding test to ignore #

Patch Set 7 : fix k1 bug #

Patch Set 8 : #

Patch Set 9 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -141 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 5 6 7 8 1 chunk +16 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLConfig.h View 1 2 3 4 2 chunks +0 lines, -10 lines 0 comments Download
M include/gpu/gl/GrGLConfig_chrome.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.h View 3 chunks +3 lines, -25 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 2 chunks +41 lines, -73 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 1 2 3 4 5 6 2 chunks +13 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 2 3 4 5 6 3 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
joshualitt
6 years, 1 month ago (2014-10-27 20:17:30 UTC) #2
bsalomon
https://codereview.chromium.org/678073005/diff/40001/src/gpu/gl/GrGLProgramDesc.cpp File src/gpu/gl/GrGLProgramDesc.cpp (left): https://codereview.chromium.org/678073005/diff/40001/src/gpu/gl/GrGLProgramDesc.cpp#oldcode270 src/gpu/gl/GrGLProgramDesc.cpp:270: GR_GL_NO_CONSTANT_ATTRIBUTES; Can you remove all references to this macro ...
6 years, 1 month ago (2014-10-27 20:32:26 UTC) #3
joshualitt
feedback incorporated
6 years, 1 month ago (2014-10-27 20:59:54 UTC) #4
bsalomon
lgtm
6 years, 1 month ago (2014-10-27 21:01:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678073005/100001
6 years, 1 month ago (2014-10-27 22:25:56 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 84c94c0dfd1e12e97d8a835882dda575f36e41d2
6 years, 1 month ago (2014-10-27 22:33:37 UTC) #10
joshualitt
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/679363002/ by joshualitt@google.com. ...
6 years, 1 month ago (2014-10-28 00:54:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678073005/120001
6 years, 1 month ago (2014-10-28 14:43:13 UTC) #13
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running git apply --index -3 -p1; error: patch ...
6 years, 1 month ago (2014-10-28 14:43:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678073005/120002
6 years, 1 month ago (2014-10-28 14:45:15 UTC) #17
commit-bot: I haz the power
Committed patchset #8 (id:120002) as 95f5194abce19e8ed875f3495fd16c79a9b931b4
6 years, 1 month ago (2014-10-28 14:55:00 UTC) #18
joshualitt
A revert of this CL (patchset #8 id:120002) has been created in https://codereview.chromium.org/683203002/ by joshualitt@google.com. ...
6 years, 1 month ago (2014-10-28 16:07:10 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/678073005/150001
6 years, 1 month ago (2014-10-28 16:51:33 UTC) #21
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 17:27:49 UTC) #22
Message was sent while issue was closed.
Committed patchset #9 (id:150001) as 0e602827df086d2bbb215d828d7fdcbbe16e792b

Powered by Google App Engine
This is Rietveld 408576698