Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 671173006: Remove lots of machinery related to inline event handlers. (Closed)

Created:
6 years, 2 months ago by esprehn
Modified:
6 years, 2 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -449 lines) Patch
M sky/engine/bindings/core/v8/V8AbstractEventListener.h View 6 chunks +3 lines, -18 lines 0 comments Download
M sky/engine/bindings/core/v8/V8AbstractEventListener.cpp View 5 chunks +5 lines, -15 lines 0 comments Download
M sky/engine/bindings/core/v8/V8ErrorHandler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/V8ErrorHandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/V8EventListener.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/V8EventListener.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/V8EventListenerList.h View 2 chunks +11 lines, -13 lines 0 comments Download
M sky/engine/bindings/core/v8/V8EventListenerList.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/V8GCController.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/bindings/scripts/v8_attributes.py View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/templates/methods.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/tests/idls/TestImplements.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/tests/idls/TestInterfaceNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/bindings/tests/idls/TestObject.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/animation/AnimationPlayer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/animation/AnimationPlayer.idl View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/core.gni View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/FontFaceSet.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/css/FontFaceSet.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/css/MediaQueryList.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/MediaQueryList.idl View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/dom/Document.h View 2 chunks +0 lines, -21 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M sky/engine/core/dom/Element.h View 1 chunk +0 lines, -14 lines 0 comments Download
M sky/engine/core/editing/ReplaceSelectionCommand.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/events/EventListener.h View 1 chunk +14 lines, -34 lines 0 comments Download
M sky/engine/core/events/EventListenerMap.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/events/EventListenerMap.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
M sky/engine/core/events/EventTarget.h View 5 chunks +0 lines, -55 lines 0 comments Download
M sky/engine/core/events/EventTarget.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
D sky/engine/core/frame/DOMWindowEventHandlers.h View 1 chunk +0 lines, -52 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.h View 1 chunk +0 lines, -13 lines 0 comments Download
M sky/engine/core/frame/Window.idl View 2 chunks +0 lines, -14 lines 0 comments Download
D sky/engine/core/frame/WindowEventHandlers.idl View 1 chunk +0 lines, -49 lines 0 comments Download
M sky/engine/core/html/ime/InputMethodContext.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/html/ime/InputMethodContext.idl View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
lgtm
6 years, 2 months ago (2014-10-23 22:40:56 UTC) #1
esprehn
6 years, 2 months ago (2014-10-23 22:42:01 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1cbca2e6b264d399186e4157ba324f760577051d.

Powered by Google App Engine
This is Rietveld 408576698