sky/engine/bindings/scripts/v8_attributes.py - Issue 671173006: Remove lots of machinery related to inline event handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/scripts/v8_attributes.py

Issue 671173006: Remove lots of machinery related to inline event handlers. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/scripts/v8_attributes.py

diff --git a/sky/engine/bindings/scripts/v8_attributes.py b/sky/engine/bindings/scripts/v8_attributes.py

index b2d724f889fcd651562ac109424d396c5034e920..eac7e38ff662819fd2d5e6939bb0dd097a3942e6 100644

--- a/sky/engine/bindings/scripts/v8_attributes.py

+++ b/sky/engine/bindings/scripts/v8_attributes.py

@@ -372,9 +372,9 @@ def setter_expression(interface, attribute, context):

if (interface.name in ['Window'] and

attribute.name == 'onerror'):

includes.add('bindings/core/v8/V8ErrorHandler.h')

- arguments.append('V8EventListenerList::findOrCreateWrapper<V8ErrorHandler>(v8Value, true, ScriptState::current(info.GetIsolate()))')

+ arguments.append('V8EventListenerList::findOrCreateWrapper<V8ErrorHandler>(v8Value, ScriptState::current(info.GetIsolate()))')

else:

- arguments.append('V8EventListenerList::getEventListener(ScriptState::current(info.GetIsolate()), v8Value, true, ListenerFindOrCreate)')

+ arguments.append('V8EventListenerList::getEventListener(ScriptState::current(info.GetIsolate()), v8Value, ListenerFindOrCreate)')

elif idl_type.is_interface_type:

# FIXME: should be able to eliminate WTF::getPtr in most or all cases

arguments.append('WTF::getPtr(cppValue)')