Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: sky/engine/bindings/core/v8/V8EventListener.cpp

Issue 671173006: Remove lots of machinery related to inline event handlers. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/core/v8/V8EventListener.h ('k') | sky/engine/bindings/core/v8/V8EventListenerList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/V8EventListener.cpp
diff --git a/sky/engine/bindings/core/v8/V8EventListener.cpp b/sky/engine/bindings/core/v8/V8EventListener.cpp
index 94e20c6f02c4a6f223c211f8b3e3e43678c4d920..962466bba107d5eaf5d2099f6b881f2bf85fab25 100644
--- a/sky/engine/bindings/core/v8/V8EventListener.cpp
+++ b/sky/engine/bindings/core/v8/V8EventListener.cpp
@@ -38,8 +38,8 @@
namespace blink {
-V8EventListener::V8EventListener(v8::Local<v8::Object> listener, bool isAttribute, ScriptState* scriptState)
- : V8AbstractEventListener(isAttribute, scriptState)
+V8EventListener::V8EventListener(v8::Local<v8::Object> listener, ScriptState* scriptState)
+ : V8AbstractEventListener(scriptState)
{
setListenerObject(listener);
}
@@ -56,7 +56,6 @@ v8::Local<v8::Function> V8EventListener::getListenerFunction(ExecutionContext*)
return v8::Local<v8::Function>::Cast(listener);
if (listener->IsObject()) {
- ASSERT_WITH_MESSAGE(!isAttribute(), "EventHandler attributes should only accept JS Functions as input.");
v8::Local<v8::Value> property = listener->Get(v8AtomicString(isolate(), "handleEvent"));
// Check that no exceptions were thrown when getting the
// handleEvent property and that the value is a function.
« no previous file with comments | « sky/engine/bindings/core/v8/V8EventListener.h ('k') | sky/engine/bindings/core/v8/V8EventListenerList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698