Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: sky/engine/bindings/core/v8/V8GCController.cpp

Issue 671173006: Remove lots of machinery related to inline event handlers. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 55
56 namespace blink { 56 namespace blink {
57 57
58 // FIXME: This should use opaque GC roots. 58 // FIXME: This should use opaque GC roots.
59 static void addReferencesForNodeWithEventListeners(v8::Isolate* isolate, Node* n ode, const v8::Persistent<v8::Object>& wrapper) 59 static void addReferencesForNodeWithEventListeners(v8::Isolate* isolate, Node* n ode, const v8::Persistent<v8::Object>& wrapper)
60 { 60 {
61 ASSERT(node->hasEventListeners()); 61 ASSERT(node->hasEventListeners());
62 62
63 EventListenerIterator iterator(node); 63 EventListenerIterator iterator(node);
64 while (EventListener* listener = iterator.nextListener()) { 64 while (EventListener* listener = iterator.nextListener()) {
65 if (listener->type() != EventListener::JSEventListenerType)
66 continue;
67 V8AbstractEventListener* v8listener = static_cast<V8AbstractEventListene r*>(listener); 65 V8AbstractEventListener* v8listener = static_cast<V8AbstractEventListene r*>(listener);
68 if (!v8listener->hasExistingListenerObject()) 66 if (!v8listener->hasExistingListenerObject())
69 continue; 67 continue;
70 68
71 isolate->SetReference(wrapper, v8::Persistent<v8::Value>::Cast(v8listene r->existingListenerObjectPersistentHandle())); 69 isolate->SetReference(wrapper, v8::Persistent<v8::Value>::Cast(v8listene r->existingListenerObjectPersistentHandle()));
72 } 70 }
73 } 71 }
74 72
75 Node* V8GCController::opaqueRootForGC(Node* node, v8::Isolate*) 73 Node* V8GCController::opaqueRootForGC(Node* node, v8::Isolate*)
76 { 74 {
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 static size_t lastUsageReportedToV8 = 0; 442 static size_t lastUsageReportedToV8 = 0;
445 443
446 size_t currentUsage = Partitions::currentDOMMemoryUsage(); 444 size_t currentUsage = Partitions::currentDOMMemoryUsage();
447 int64_t diff = static_cast<int64_t>(currentUsage) - static_cast<int64_t>(las tUsageReportedToV8); 445 int64_t diff = static_cast<int64_t>(currentUsage) - static_cast<int64_t>(las tUsageReportedToV8);
448 isolate->AdjustAmountOfExternalAllocatedMemory(diff); 446 isolate->AdjustAmountOfExternalAllocatedMemory(diff);
449 447
450 lastUsageReportedToV8 = currentUsage; 448 lastUsageReportedToV8 = currentUsage;
451 } 449 }
452 450
453 } // namespace blink 451 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/bindings/core/v8/V8EventListenerList.cpp ('k') | sky/engine/bindings/scripts/v8_attributes.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698