Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: sky/engine/core/events/EventListenerMap.cpp

Issue 671173006: Remove lots of machinery related to inline event handlers. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/events/EventListenerMap.h ('k') | sky/engine/core/events/EventTarget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/events/EventListenerMap.cpp
diff --git a/sky/engine/core/events/EventListenerMap.cpp b/sky/engine/core/events/EventListenerMap.cpp
index e2567ed420582b07d5626a5866fee54f51b69407..435aabaa128caa275dee6faf088b868a89c6b81d 100644
--- a/sky/engine/core/events/EventListenerMap.cpp
+++ b/sky/engine/core/events/EventListenerMap.cpp
@@ -169,53 +169,6 @@ EventListenerVector* EventListenerMap::find(const AtomicString& eventType)
return 0;
}
-static void removeFirstListenerCreatedFromMarkup(EventListenerVector* listenerVector)
-{
- bool foundListener = false;
-
- for (size_t i = 0; i < listenerVector->size(); ++i) {
- if (!listenerVector->at(i).listener->wasCreatedFromMarkup())
- continue;
- foundListener = true;
- listenerVector->remove(i);
- break;
- }
-
- ASSERT_UNUSED(foundListener, foundListener);
-}
-
-void EventListenerMap::removeFirstEventListenerCreatedFromMarkup(const AtomicString& eventType)
-{
- assertNoActiveIterators();
-
- for (unsigned i = 0; i < m_entries.size(); ++i) {
- if (m_entries[i].first == eventType) {
- removeFirstListenerCreatedFromMarkup(m_entries[i].second.get());
- if (m_entries[i].second->isEmpty())
- m_entries.remove(i);
- return;
- }
- }
-}
-
-static void copyListenersNotCreatedFromMarkupToTarget(const AtomicString& eventType, EventListenerVector* listenerVector, EventTarget* target)
-{
- for (size_t i = 0; i < listenerVector->size(); ++i) {
- // Event listeners created from markup have already been transfered to the shadow tree during cloning.
- if ((*listenerVector)[i].listener->wasCreatedFromMarkup())
- continue;
- target->addEventListener(eventType, (*listenerVector)[i].listener, (*listenerVector)[i].useCapture);
- }
-}
-
-void EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget(EventTarget* target)
-{
- assertNoActiveIterators();
-
- for (unsigned i = 0; i < m_entries.size(); ++i)
- copyListenersNotCreatedFromMarkupToTarget(m_entries[i].first, m_entries[i].second.get(), target);
-}
-
EventListenerIterator::EventListenerIterator()
: m_map(0)
, m_entryIndex(0)
« no previous file with comments | « sky/engine/core/events/EventListenerMap.h ('k') | sky/engine/core/events/EventTarget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698