Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: sky/engine/bindings/core/v8/V8EventListenerList.cpp

Issue 671173006: Remove lots of machinery related to inline event handlers. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/core/v8/V8EventListenerList.h ('k') | sky/engine/bindings/core/v8/V8GCController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/V8EventListenerList.cpp
diff --git a/sky/engine/bindings/core/v8/V8EventListenerList.cpp b/sky/engine/bindings/core/v8/V8EventListenerList.cpp
index a4c9a6fc26c0bc487ffe0a8f85b56d5b997d039c..45a6072325d9aca313da1abc8a6582135d3cad9f 100644
--- a/sky/engine/bindings/core/v8/V8EventListenerList.cpp
+++ b/sky/engine/bindings/core/v8/V8EventListenerList.cpp
@@ -36,18 +36,17 @@
namespace blink {
-PassRefPtr<EventListener> V8EventListenerList::getEventListener(ScriptState* scriptState, v8::Local<v8::Value> value, bool isAttribute, ListenerLookupType lookup)
+PassRefPtr<EventListener> V8EventListenerList::getEventListener(ScriptState* scriptState, v8::Local<v8::Value> value, ListenerLookupType lookup)
{
ASSERT(!scriptState->contextIsEmpty());
if (lookup == ListenerFindOnly) {
// Used by EventTarget::removeEventListener, specifically
// EventTargetV8Internal::removeEventListenerMethod
- ASSERT(!isAttribute);
return V8EventListenerList::findWrapper(value, scriptState);
}
if (toDOMWindow(scriptState->context()))
- return V8EventListenerList::findOrCreateWrapper<V8EventListener>(value, isAttribute, scriptState);
+ return V8EventListenerList::findOrCreateWrapper<V8EventListener>(value, scriptState);
ASSERT_NOT_REACHED();
return nullptr;
« no previous file with comments | « sky/engine/bindings/core/v8/V8EventListenerList.h ('k') | sky/engine/bindings/core/v8/V8GCController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698