Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: sky/engine/bindings/core/v8/V8ErrorHandler.h

Issue 671173006: Remove lots of machinery related to inline event handlers. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/bindings/core/v8/V8ErrorHandler.h
diff --git a/sky/engine/bindings/core/v8/V8ErrorHandler.h b/sky/engine/bindings/core/v8/V8ErrorHandler.h
index 3b9fc51948031c22a9ffce6b300e1042d09f96cb..547126ce2a47f2c3fc60ee8d363f8da7bc7a4110 100644
--- a/sky/engine/bindings/core/v8/V8ErrorHandler.h
+++ b/sky/engine/bindings/core/v8/V8ErrorHandler.h
@@ -42,15 +42,15 @@ class LocalFrame;
class V8ErrorHandler FINAL : public V8EventListener {
public:
- static PassRefPtr<V8ErrorHandler> create(v8::Local<v8::Object> listener, bool isInline, ScriptState* scriptState)
+ static PassRefPtr<V8ErrorHandler> create(v8::Local<v8::Object> listener, ScriptState* scriptState)
{
- return adoptRef(new V8ErrorHandler(listener, isInline, scriptState));
+ return adoptRef(new V8ErrorHandler(listener, scriptState));
}
static void storeExceptionOnErrorEventWrapper(ErrorEvent*, v8::Handle<v8::Value>, v8::Handle<v8::Object> creationContext, v8::Isolate*);
private:
- V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline, ScriptState*);
+ V8ErrorHandler(v8::Local<v8::Object> listener, ScriptState*);
virtual v8::Local<v8::Value> callListenerFunction(v8::Handle<v8::Value> jsEvent, Event*) OVERRIDE;
virtual bool shouldPreventDefault(v8::Local<v8::Value> returnValue) OVERRIDE;
« no previous file with comments | « sky/engine/bindings/core/v8/V8AbstractEventListener.cpp ('k') | sky/engine/bindings/core/v8/V8ErrorHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698